Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

huijie - schedule meeting bell notification #1154

Open
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

metaphor987
Copy link
Contributor

@metaphor987 metaphor987 commented Nov 17, 2024

Description

task

Related PRS (if any):

This backend PR is related to the #2878 frontend PR(OneCommunityGlobal/HighestGoodNetworkApp#2878).

Main changes explained:

  1. Implement a new meeting schema in the database.
  2. Implement APIs to post a new meeting, to get all meetings within a specific time range

Known bugs:

The bell does not ring for the first meeting notification displayed but rings for subsequent ones. This happens because browsers block the autoplay of audio or video until the user interacts with the page (e.g., by clicking or tapping). A possible solution could be to display a preview notification for the upcoming meeting, prompting the user to click a button on the page, which would then allow the bell to ring for future notifications.

How to test:

  1. check into current branch
  2. do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. log as admin/owner user
  5. go to dashboard→ Other Links→ Schedule Meetings
  6. verify that an admin/owner user can fill in the information in the scheduling form. After clicking the "Submit" button, a message should display the details of the meeting the user has just scheduled.
  7. Log in as one of the recipients of the scheduled meeting. If the meeting is scheduled within 3 days from the current date, the recipient should see notifications for the meetings they need to attend after logging in. After clicking the "Cancel" button, the current notification should no longer be displayed. Notifications for other meetings, if available, should then be shown.

Screenshots or videos of changes:

schedule meeting page
notification page

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Nov 27, 2024
@metaphor987 metaphor987 force-pushed the huijie-schedule-meeting-bell-notification branch from 552c36f to 4955236 Compare December 1, 2024 02:46
@one-community one-community added the Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. label Dec 1, 2024
@mashpotato9
Copy link

everything worked as expected, review left on #2878

Copy link

@kobakvantrishvili kobakvantrishvili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am having trouble selecting participants to schedule the meeting with. it's not letting me select the participant even if I type in the full name, therefore I am unable to test whether or not the notification is sent out. I'm not sure why this is happening. If I double click it selects the person and then quickly deselects him, when clicking once nothing happens. I tried this out in multiple browsers and in private mode and this front end issue still persists.

bug1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants