Chengyan phase2 reusables list #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TareqMia
approved these changes
Feb 17, 2024
There was a problem hiding this comment.
Hi @ChengyanOo, I have reviewed the code for this PR and everything looks good and is functioning 👍 I have also left some comments on the related front-end PR.
meetpadhiar4
approved these changes
Feb 19, 2024
ShengjieMao
approved these changes
Feb 20, 2024
XiaohanMeng
approved these changes
Feb 23, 2024
brandta-1
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
Review
Routes correctly pulled reusable buildingInventoryItems and also correctly pulled custom items made for testing.
Video
See front end review
ramyaram2092
pushed a commit
that referenced
this pull request
Apr 5, 2024
…bles-List Chengyan phase2 reusables list
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This backend update complements the frontend PR Chengyan phase2 reusables list UI #1956, introducing a REST endpoint for get and delete reusable items as part of the Phase Two development of the HGN app.
Related PRS (if any):
Chengyan phase2 reusables list UI #1956
Main changes explained:
bmReusableController.jsto facilitate the REST endpoint for get and delete reusables.How to test:
npm install,npm run build, andnpm run startto run this PR locally.Screenshots or videos of changes:
Detailed walk through:
https://www.loom.com/share/f2a55f5d317f4e979627765edf1fa9a6?sid=2c390651-9dad-4c52-b12d-2a4b12c9dc97