Fix X hours in X weeks streak badges #890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_entry_blue_square Roberto-fixes logic to push to the edit time entry history
…GNRest into navneeth_add_google_doc_link_to_weekly_summaries_email
Backend Release to Main [1.54]
…lySummaryReport: { type: Date, default: undefined }, this will now be updated each to match the date, when a recipient was added
…lySummaryReport: { type: Date, default: undefined }, this will now be updated each to match the date, when a recipient was added
…nto Sucheta-refactor-weeklySummaryRecipient-button
…lySummaryRecipient-button Sucheta- Refactor WeeklySummaryRecipient Button Functionality
…nto shengwei_add_jae_account_edit_permission
…_Duplicate_Badges Roberto fix assigning duplicate badges
…mentor_will_make_user_invisible XiaoW_Hotfix of adding check for role in putUserProfile controller to make mentor invisible
…unt_edit_permission Shengwei add Jae account edit permission
…n_email fix blue square reason email
chore: deleted all related test changes leaving current functionality
one-community
temporarily deployed
to
Production
GitHub Actions
Inactive
…solved Diego merge conflict solved
one-community
temporarily deployed
to
Production
GitHub Actions
Inactive
…ls_backend_linked chris_equipment_details_backend_linked
one-community
temporarily deployed
to
Production
GitHub Actions
Inactive
…ckbox_user_profile_backend Jingyi-User Profile: Rehireable / Notrehireable Check Box
one-community
temporarily deployed
to
Production
GitHub Actions
Inactive
…ng-self Nathan prevent user from deleting self
one-community
temporarily deployed
to
Production
GitHub Actions
Inactive
…emails_notifications Fix time off request notification not being sent to the owner
one-community
temporarily deployed
to
Production
GitHub Actions
Inactive
…bles_request_form_backend Aishwarya-Purchase-Consumable-Request-Form-(Backend)
one-community
temporarily deployed
to
Production
GitHub Actions
Inactive
skaush21
reviewed
Apr 16, 2024
There was a problem hiding this comment.
The version I tested this on may be outdated but I just thought I'd mention that Before merging, please ensure to adjust the files edited for testing purposes. For example, revert 'userProfilJobs.js' to:
'1 0 * * 0', // Every Sunday, 1 minute past midnight.
- Extensively tested PR 890, added two sets of 30hrs to savedtangiblehrs, checked badgecollection did not receive a 30hr badge
(notes mentioned if badge doesnt appear in badgecollection, badge doesnt exist.)
-
added two sets of 40hrs via frontend ‘addtimeentry’
this method increased the existing count by 1 for 40hrs streak for 1 week -
did the following for 30 hrs as well, since badge doesnt exist, it didnt increase the count
PR.890.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related PRS (if any):
To test this backend PR you need to check the latest frontend
Main changes explained:
it was included a simple logic in checkXHoursXWeeks function
…
How to test:
npm installand...to run this PR locallysee the tutorials how to test below:
2024-04-10.17-31-59.mov
2024-04-10.17-36-47.mov
2024-04-10.17-39-23.mov
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.
Some questions please send me a dm in slack