Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jiayu --> Demi_add_previous_page_redirect #1855

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

this-journey
Copy link
Contributor

@this-journey this-journey commented Jan 19, 2024

Description

Implements Phase 2 WBS Bugs line item 5 “Login”

Related PRS (if any):

Use the development branch for the back end.

Main changes explained:

  • Redirects user to the previous page after log in on the BM Dashboard

How to test:

  1. pull the latest code
  2. check into current branch
  3. npm install
  4. npm run start:local to run this PR locally
  5. Clear site data/cache in local storage
  6. log in as any user
  7. go to a page of bmdashboard that requires authentication such as http://localhost:3000/bmdashboard/materials
  8. since you are not authenticated, you will be redirect to bmdashboard/login
  9. after successfully logged in, verify that you will be redirect to bmdashboard/materials (or any original page) page

Screenshots or videos of changes:

https://www.loom.com/share/7ebc7400d6c8402d976ddd0b6038eeff?sid=0b40deae-2fdc-40d2-bf41-1bc6dd43476e

Note:

Accessing bmdashboard/login directly from URL will not trigger redirection.

@Chuehleo Chuehleo added do not review Do not review or look at code without full context and removed do not review labels May 1, 2024
@peter6866 peter6866 removed the do not review Do not review or look at code without full context label Jun 7, 2024
@peter6866 peter6866 requested a review from tdkent June 12, 2024 19:26
@one-community one-community changed the title Demi_add_previous_page_redirect Jiayu --> Demi_add_previous_page_redirect Jun 25, 2024
@one-community one-community merged commit e6f4d0d into development Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants