Nahiyan_Added a "Edit Tasks" button to reduce the number of requests #2013

Nahiyan-16 · 2024-03-01T23:24:27Z

Description

Added this button because before on-page initialization, the app would have to make too many unnecessary requests to the backend. Now when the users want to edit tasks, they may click the new button which will then make all the requests to the backend needed.

Related PRS (if any):

This frontend PR is related to the dev backend

Main changes explained:

-Added a "Edit tasks" button
-Should be disabled on page load
-When clicked should allow the user to edit tasks

How to test:

check into current branch
do npm install and npm run start:local to run this PR locally
Clear site data/cache
log as owner user
go to dashboard→ reports→ Projects -> any project
verify that edit tasks button is there
verify that edit button is hidden for each task
verify that when clicking on edit tasks button, it enables the edit button next to each tasks
look at network tab to see if requests are being made after clicking on edit tasks button

Screenshots or videos of changes:

Before clicking "Edit Tasks" button

After clicking "Edit Tasks" button

Added this button because before on page initialization, the app would have to make too many unnecessary requests to the backend. Now when the users wants to edit tasks, they may click the new button which will then make all the requests to the backend needed.

MALAV1308

Hello , I reviewed your PR and I can not able to see tasks in task menu and got some warnings. Please look into it and solve it.

abdel-lall

This PR has console errors and unnecessary logs.

Nahiyan-16 · 2024-03-04T17:54:39Z

This PR has console errors and unnecessary logs.

@abdel-lall @MALAV1308 Thanks for the reviews and I have fixed the console log errors.

meetpadhiar4

Hi, I tested your PR and have encountered few issues. The tasks are not loading on the project info page and when I click the edit task button, no requests are being sent to the server. Please refer the video attached.

PR.2013.mov

Pandani07

Im not able to see the tasks and clicking on edit tasks sends no request to the network

Screen.Recording.2024-03-05.at.10.03.38.PM.mov

dhairya-mehta · 2024-03-12T18:48:17Z

Hey, I observed no changes after clicking on Edit tasks

iven-yao

I just reviewed this pull request
I logged in as an owner role, go to a project reports from Reports->Projects.

there's an Edit Tasks button
Edit button of each task is disabled --> Not disabled but hidden
after clicking Edit Tasks, making more request and show the edit button for each task

please make sure if we need task button for each task being hidden or disabled before clicking edit tasks button.

Nahiyan-16 · 2024-04-01T17:29:14Z

I just reviewed this pull request I logged in as an owner role, go to a project reports from Reports->Projects.

there's an Edit Tasks button

Edit button of each task is disabled --> Not disabled but hidden

after clicking Edit Tasks, making more request and show the edit button for each task

please make sure if we need task button for each task being hidden or disabled before clicking edit tasks button.

Yes, the Edit Tasks button should be hidden. The implementation was correct but the description was not.

iven-yao

after clarifying the request, I approve this change according to previous review

Gayathr-2012 · 2024-04-01T23:00:00Z

I just followed this steps it works perfect as expected.
I logged in as an owner role, go to a project reports from Reports->Projects.

there's an Edit Tasks button
Edit button of each task is disabled --> Not disabled but hidden
after clicking Edit Tasks, making more request and show the edit button for each task
please make sure if we need task button for each task being hidden or disabled before clicking edit tasks button.

but I noticed when I clicked on console I saw error on user profile. please correct it.

meetpadhiar4

Hi, I reviewed your PR and it is working as intended.

kylepham

PR worked as described.

Screen.Recording.2024-04-02.at.2.48.54.PM.mov

Tiantian-C

The function works,while it has some unexpected errors in the console.

SRamen1999

Requests are being made after clicking on edit tasks button. However I am also getting an error in the console.

Screen.Recording.2024-04-05.at.11.24.31.AM.mov

This is the error

anandsesha

Hi, I've reviewed your PR and the changes work as expected.

Logged in as Owner user, verified the Edit Task button is there and each Edit button is hidden, which is only enabled on clicking Edit Task.
Verified Networks tab to see requests made when Edit Task is clicked

aaryaneil

I have reviewed this PR and the changes work as intended.

Screen.Recording.2024-04-14.at.1.26.06.AM.mov

jennZhang93

Tested with the owner account and all features described in the PR worked. Good job!

cgomezhub

The functionality is working, well done!.
the UI needs general improvements

https://www.loom.com/share/cebfd39908934a7d9196f89d365d2180?sid=c0e9e4f4-c524-427a-8116-da762663a033

ZhangPeizhou · 2024-05-31T14:33:04Z

The code works as expected

…ighestGoodNetworkApp into Nahiyan_Optimize-Project-Report-Page

JatinAgrawal94

Edit Sign is visible and is working.
Console has an error: "Warning: validateDOMNesting(...):

cannot appear as a child of ."
At some page sizes the headings in task table overlap with each other.
Number of requests do not increase to a large number on clicking edit button.
Rest everything works fine.
Great work!

PR.2013.mp4

akshit0211

Hi, the functionality is working as expected but there are some warnings in the console. Please look into this.

…ighestGoodNetworkApp into Nahiyan_Optimize-Project-Report-Page

one-community · 2024-07-09T19:02:21Z

Thank you all, merging!

Nahiyan-16 added 3 commits February 27, 2024 16:32

tasks table not loading fix

822c6a0

Fixed unit test

959d39e

MALAV1308 suggested changes Mar 3, 2024

View reviewed changes

abdel-lall requested changes Mar 3, 2024

View reviewed changes

Nahiyan-16 added the do not review label Mar 3, 2024

Fixed all the console errors

59845ef

Nahiyan-16 removed the do not review label Mar 4, 2024

Nahiyan-16 requested review from MALAV1308 and abdel-lall March 4, 2024 17:41

meetpadhiar4 suggested changes Mar 5, 2024

View reviewed changes

Pandani07 requested changes Mar 6, 2024

View reviewed changes

Fixed tasks not appearing in the table

7d30886

Nahiyan-16 requested review from Pandani07 and meetpadhiar4 March 13, 2024 16:57

one-community added the High Priority - Please Review First label Mar 30, 2024

iven-yao suggested changes Mar 31, 2024

View reviewed changes

Nahiyan-16 requested a review from iven-yao April 1, 2024 17:30

iven-yao previously approved these changes Apr 1, 2024

View reviewed changes

Merge branch 'development' into Nahiyan_Optimize-Project-Report-Page

98b0328

Nahiyan-16 dismissed iven-yao’s stale review via 98b0328 April 2, 2024 17:33

meetpadhiar4 previously approved these changes Apr 2, 2024

View reviewed changes

kylepham previously approved these changes Apr 2, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

Tiantian-C reviewed Apr 4, 2024

View reviewed changes

SRamen1999 reviewed Apr 5, 2024

View reviewed changes

anandsesha previously approved these changes Apr 6, 2024

View reviewed changes

aaryaneil previously approved these changes Apr 14, 2024

View reviewed changes

jennZhang93 previously approved these changes Apr 18, 2024

View reviewed changes

Chuehleo added High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible and removed High Priority - Please Review First labels May 1, 2024

cgomezhub previously approved these changes May 7, 2024

View reviewed changes

Merge branch 'development' into Nahiyan_Optimize-Project-Report-Page

4798b11

Nahiyan-16 dismissed stale reviews from cgomezhub, jennZhang93, aaryaneil, anandsesha, kylepham, and meetpadhiar4 via 4798b11 May 28, 2024 14:40

Nahiyan-16 added 2 commits May 31, 2024 11:04

Merge branch 'development' of https://github.com/OneCommunityGlobal/H…

a870045

…ighestGoodNetworkApp into Nahiyan_Optimize-Project-Report-Page

Tasks now appear in Tasks table

48c7558

JatinAgrawal94 requested changes Jun 5, 2024

View reviewed changes

Nahiyan-16 added 2 commits June 7, 2024 16:36

Complete redesign of tasks table

ba0ddbb

Update EditTaskModal.jsx

b53f9f4

Nahiyan-16 requested a review from JatinAgrawal94 June 10, 2024 19:17

JatinAgrawal94 previously approved these changes Jun 10, 2024

View reviewed changes

akshit0211 requested changes Jun 13, 2024

View reviewed changes

Merge branch 'development' into Nahiyan_Optimize-Project-Report-Page

0fa902d

Nahiyan-16 dismissed JatinAgrawal94’s stale review via 0fa902d July 4, 2024 18:24

Nahiyan-16 added 2 commits July 9, 2024 11:06

Merge branch 'development' of https://github.com/OneCommunityGlobal/H…

56b55d8

…ighestGoodNetworkApp into Nahiyan_Optimize-Project-Report-Page

Update TasksTable.jsx

3cb8060

one-community merged commit fe996e1 into development Jul 9, 2024
1 check passed

one-community mentioned this pull request Jul 17, 2024

Frontend Release to Main [3.66] #2458

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nahiyan_Added a "Edit Tasks" button to reduce the number of requests #2013

Nahiyan_Added a "Edit Tasks" button to reduce the number of requests #2013

Nahiyan-16 commented Mar 1, 2024 •

edited

Loading

MALAV1308 left a comment

abdel-lall left a comment

Nahiyan-16 commented Mar 4, 2024

meetpadhiar4 left a comment

Pandani07 left a comment •

edited

Loading

dhairya-mehta commented Mar 12, 2024

iven-yao left a comment

Nahiyan-16 commented Apr 1, 2024

iven-yao left a comment

Gayathr-2012 commented Apr 1, 2024 •

edited

Loading

meetpadhiar4 left a comment

kylepham left a comment

This comment was marked as resolved.

Tiantian-C left a comment

SRamen1999 left a comment

anandsesha left a comment

aaryaneil left a comment

jennZhang93 left a comment

cgomezhub left a comment

ZhangPeizhou commented May 31, 2024

JatinAgrawal94 left a comment

akshit0211 left a comment •

edited

Loading

one-community commented Jul 9, 2024

Nahiyan_Added a "Edit Tasks" button to reduce the number of requests #2013

Nahiyan_Added a "Edit Tasks" button to reduce the number of requests #2013

Conversation

Nahiyan-16 commented Mar 1, 2024 • edited Loading

Description

Related PRS (if any):

Main changes explained:

How to test:

Screenshots or videos of changes:

MALAV1308 left a comment

Choose a reason for hiding this comment

abdel-lall left a comment

Choose a reason for hiding this comment

Nahiyan-16 commented Mar 4, 2024

meetpadhiar4 left a comment

Choose a reason for hiding this comment

Pandani07 left a comment • edited Loading

Choose a reason for hiding this comment

dhairya-mehta commented Mar 12, 2024

iven-yao left a comment

Choose a reason for hiding this comment

Nahiyan-16 commented Apr 1, 2024

iven-yao left a comment

Choose a reason for hiding this comment

Gayathr-2012 commented Apr 1, 2024 • edited Loading

meetpadhiar4 left a comment

Choose a reason for hiding this comment

kylepham left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

Tiantian-C left a comment

Choose a reason for hiding this comment

SRamen1999 left a comment

Choose a reason for hiding this comment

anandsesha left a comment

Choose a reason for hiding this comment

aaryaneil left a comment

Choose a reason for hiding this comment

jennZhang93 left a comment

Choose a reason for hiding this comment

cgomezhub left a comment

Choose a reason for hiding this comment

ZhangPeizhou commented May 31, 2024

JatinAgrawal94 left a comment

Choose a reason for hiding this comment

akshit0211 left a comment • edited Loading

Choose a reason for hiding this comment

one-community commented Jul 9, 2024

Nahiyan-16 commented Mar 1, 2024 •

edited

Loading

Pandani07 left a comment •

edited

Loading

Gayathr-2012 commented Apr 1, 2024 •

edited

Loading

akshit0211 left a comment •

edited

Loading