Peterson_Fix_Weekly_Summaries_edit_Last_week #2023

peterson337 · 2024-03-04T23:23:47Z

Description

In the HGN software, specifically within the 'Tasks and Timelogs' card on the Dashboard, there is a tab named 'Weekly Summaries,' which displays three editable summaries. Upon clicking the 'edit' button below each summary, two additional buttons, 'save' and 'cancel,' appear. The bug was found in the 'save' button functionality, which, when triggered, initiated a 'put' request resulting in two errors. The first error occurred because Node did not receive information from React, resulting in an HTTP status code 500, indicating a server error. The second error was related to the frontend-to-backend request: the request URL should have contained the user ID but was instead sent as 'undefined.'

priority Medium

Related PRS (if any):

This frontend PR is associated with the following backend PR: OneCommunityGlobal/HGNRest#781

Main changes explained:

The WeeklySummaries component has been modified to fix the bugs.

How to test:

check into current branch
do npm install and npm start to run this PR locally
log as any user.
Go to Dashboard → Weekly Summaries.
Click the "Edit" button.
After editing the desired summary, click the "Save" button.
Open the browser's Developer Tools by pressing F12 or right-clicking and selecting 'Inspect.' Navigate to the 'Console' tab. Check if the following errors appear in the console:
If the errors shown in the image above do not appear and the summary has been edited successfully, reload the page and check if the summary remains edited.

Screenshots or videos of changes:

Note:

The console is going to have some errors not related to this PR. These can be disregarded because the code changed by this PR will not introduce these errors to the "development" branch when it gets merged.

meetpadhiar4

Hi, I tested your PR and it works as intended. I was able to edit the summary without any errors and the communication between the server and the frontend is happening properly resulting in 200 status code. Refer the video attached for reference.

PR.2023.mov

nnamdixobi · 2024-03-08T23:17:16Z

Everything compiles as expected but for some reason it wont let me save a weekly summary for testing

psharma1984

Hi @peterson337 I reviewed and its working as expected. Able to edit the summary and its saved and remains updated when page is refreshed

hetvi11110

I tested this PR as mentioned. It is working fine on my local server. Here is the screenshot.

Tiantian-C

I have tested the function,and it works well!

Abi-Liu

Hey! Overall the code works as expected. However, there is one small bug I encountered. When editing the weekly summaries, if a user tries to save an invalid summary (either blank or less than 50 words), the error will fire as expected but the button will stay disabled. This forces the user to refresh and then make the changes again before being allowed to update.

This can be fixed by just setting the LoadingHandleSave state to null if an error occurs.

EDIT: Also no need to await setLoadingHandleSave on line 92 in src/components/Timelog/WeeklySummaries.jsx

video1131734987.mp4

Abi-Liu · 2024-03-13T03:20:23Z

src/actions/weeklySummaries.js

@@ -79,7 +79,8 @@ export const updateWeeklySummaries = (userId, weeklySummariesData) => {

      // Merge the weekly summaries related changes with the user's profile.
      const {mediaUrl, weeklySummaries, weeklySummariesCount } = weeklySummariesData;
-      console.log('respon get', response.data)
+
+      // console.log('respon get', response.data)


Remove console.log

I removed the console.log from the weeklySummaries.js archive.

peterson337 · 2024-03-13T17:50:47Z

Hey! Overall the code works as expected. However, there is one small bug I encountered. When editing the weekly summaries, if a user tries to save an invalid summary (either blank or less than 50 words), the error will fire as expected but the button will stay disabled. This forces the user to refresh and then make the changes again before being allowed to update.

This can be fixed by just setting the LoadingHandleSave state to null if an error occurs.

EDIT: Also no need to await setLoadingHandleSave on line 92 in src/components/Timelog/WeeklySummaries.jsx

video1131734987.mp4

I fixed the bug. See my gif for more reference:

Abi-Liu

Just an extra set state that is setting the state to the same value. Other than that the changes look good!

src/components/Timelog/WeeklySummaries.jsx

Abi-Liu · 2024-03-13T20:13:07Z

src/components/Timelog/WeeklySummaries.jsx

-    } else {
-      // Invalid summary, show an error message or handle it as needed
-      alert('Please enter a valid summary with at least 50 words.');
+    await setLoadingHandleSave(null);


Delete the await setLoadingHandleSave line. Sorry I quoted the wrong code snippet in my other comment

Hi Abi-Liu. I removed the setLoadingHandleSave from the handleSave function.

It's still there. Underneath await dispatch(getUserProfile(userProfile._id)); There's 2 setLoadingHandleSave(null)

SanketKaware · 2024-03-15T00:52:41Z

Followed all the mentioned steps and the changes look good to me. Those errors didn't appear.

Screen.Recording.2024-03-14.at.8.47.06.PM.mov

Abi-Liu

Looks good!

20chen-7

npm run locally, the function looks good. but when I run npm start, npm test errors occur.

SRamen1999

This PR works as intended. I was able to edit the summary without any errors and the communication between the server and the frontend is happening properly resulting in 200 status code.

Screen.Recording.2024-03-15.at.5.39.06.PM.mov

There is also a safe check to see if the user edits the summary less than 50 words.

rajnada · 2024-03-16T02:19:01Z

Hii,

I have tested the functionality and it is working fine!
Good Job

Before :

After :

PratimaSingh02

Hi I took the following steps to execute this PR:

Logged in as an owner
Created a test weekly summary
Edited the weekly summary
Verified that the server error was not there
Reloaded the page to check if the edit was still present

sameersdeshpande

Hello @peterson337
The changes are working as expected. I checked in to current branch and logged in as a user and edited the summary and found no errors in console. It was with 200 ok status.
Thanks

iven-yao

tested the edit function in weekly summaries, and it works perfect without any error in console, and reflect the editing after save correctly.

PR2023.mp4

ImzIssa

Hey, I've tested this PR and the functionality seems to be implemented correctly. Nice work!

I do have a minor suggestion to enhance the UI. Consider using the reactstrap Alert inplace of the browser alert.

the alert when creating a summary

ImzIssa · 2024-03-17T13:19:32Z

src/components/Timelog/WeeklySummaries.jsx

  const [editedSummaries, setEditedSummaries] = useState([
    userProfile.weeklySummaries[0]?.summary || '',
    userProfile.weeklySummaries[1]?.summary || '',
    userProfile.weeklySummaries[2]?.summary || '',
  ]);
  const [originalSummaries, setOriginalSummaries] = useState([...editedSummaries]);

+  const [LoadingHandleSave, setLoadingHandleSave] = useState(null);


// Consider refactoring to use camelCase for consistency everywhere in the codebase.
const [loadingHandleSave, setLoadingHandleSave] = useState(null);

mohabbasd

Hello, I tested your PR and it works perfectly. Below is a video for reference.

Screen.Recording.2024-03-23.at.12.42.06.AM.mov

Coops023

Hi i reviewed this PR and was able to edit summaries with out an error! good job.

anandsesha · 2024-03-24T01:08:33Z

Hi, I have tested this functionality with its associated backend PR #781, logging in as admin user and volunteer user.

Created weekly summary and while editing that summary checked console and the mentioned error is not seen.
After saving the edit, inspected Network tab which results in status 200 Ok as expected.
Reloaded page and Edited summary is persisted.
Issue reported earlier of summary less than 50 is not allowed. Appropriate message shown.

Below screenshots for reference:

Sarthak32

Hi , I tested your PR. Everything works as expected but for some reason it does not let me save my edited summary.

Jaiwin-4998

Hi, I have tested you PR and it works properly. The description remains the edited after the changes and no errors.

kylepham

Everything works as expected. New summary edit was successfully saved and returned 200 status code. 50-word guard also worked.

Before:

After:

rajnada · 2024-03-30T15:24:36Z

Hii,

I have tested the PR. It works completely fine! Good Job.

MQChen211 · 2024-04-03T18:59:56Z

Hi, I tested your PR and it works as expected.

…st_week

aaryaneil

Tested the PR and there was no error generated while editing summary.

https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/assets/39597927/61df8d27-730b-43df-98c6-e7713b7a27d3

one-community · 2024-04-29T02:56:21Z

Thank you all, merging!

one-community · 2024-05-01T05:29:44Z

Thank you all, merging!

Peterson_Fix_Weekly_Summaries_edit_Last_week’s

5b11268

peterson337 mentioned this pull request Mar 4, 2024

Peterson_Fix_the_500_error_in_editing_last_week OneCommunityGlobal/HGNRest#781

Merged

peterson337 changed the title ~~Peterson_Fix_Weekly_Summaries_edit_Last_week’s~~ Peterson_Fix_Weekly_Summaries_edit_Last_week Mar 4, 2024

peterson337 mentioned this pull request Mar 5, 2024

Peterson_Fix_Weekly_Summaries_edit_Last_week's #2012

Closed

meetpadhiar4 previously approved these changes Mar 7, 2024

View reviewed changes

one-community added the High Priority - Please Review First label Mar 10, 2024

psharma1984 previously approved these changes Mar 10, 2024

View reviewed changes

hetvi11110 previously approved these changes Mar 11, 2024

View reviewed changes

Tiantian-C previously approved these changes Mar 13, 2024

View reviewed changes

Tiantian-C closed this Mar 13, 2024

Tiantian-C reopened this Mar 13, 2024

Abi-Liu requested changes Mar 13, 2024

View reviewed changes

Peterson_impl_feature_Finish_My_Team_filter_or_Tasks_Tab

c67131d

peterson337 dismissed stale reviews from Tiantian-C, hetvi11110, psharma1984, and meetpadhiar4 via c67131d March 13, 2024 16:44

peterson337 requested a review from Abi-Liu March 13, 2024 17:53

Abi-Liu requested changes Mar 13, 2024

View reviewed changes

src/components/Timelog/WeeklySummaries.jsx Show resolved Hide resolved

Abi-Liu reviewed Mar 13, 2024

View reviewed changes

Peterson_impl_feature_Finish_My_Team_filter_or_Tasks_Tab

3cf2784

peterson337 requested a review from Abi-Liu March 14, 2024 12:41

Abi-Liu previously approved these changes Mar 15, 2024

View reviewed changes

20chen-7 reviewed Mar 15, 2024

View reviewed changes

SanketKaware previously approved these changes Mar 15, 2024

View reviewed changes

SRamen1999 reviewed Mar 15, 2024

View reviewed changes

PratimaSingh02 previously approved these changes Mar 16, 2024

View reviewed changes

sameersdeshpande previously approved these changes Mar 16, 2024

View reviewed changes

iven-yao previously approved these changes Mar 17, 2024

View reviewed changes

ImzIssa previously approved these changes Mar 17, 2024

View reviewed changes

mohabbasd previously approved these changes Mar 23, 2024

View reviewed changes

Coops023 previously approved these changes Mar 23, 2024

View reviewed changes

Sarthak32 reviewed Mar 24, 2024

View reviewed changes

Jaiwin-4998 previously approved these changes Mar 27, 2024

View reviewed changes

kylepham previously approved these changes Mar 27, 2024

View reviewed changes

KurtisIvey added the Moved to Final Review label Mar 30, 2024

one-community removed the High Priority - Please Review First label Apr 4, 2024

Merge branch 'development' into Peterson_Fix_Weekly_Summaries_edit_La…

4183794

…st_week

peterson337 dismissed stale reviews from kylepham, Jaiwin-4998, Coops023, mohabbasd, ImzIssa, iven-yao, sameersdeshpande, PratimaSingh02, SanketKaware, and Abi-Liu via 4183794 April 16, 2024 17:09

aaryaneil approved these changes Apr 20, 2024

View reviewed changes

one-community merged commit dccb1c9 into development May 1, 2024
1 check passed

one-community mentioned this pull request May 1, 2024

Frontend Release to Main [3.49] #2218

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Peterson_Fix_Weekly_Summaries_edit_Last_week #2023

Peterson_Fix_Weekly_Summaries_edit_Last_week #2023

peterson337 commented Mar 4, 2024

meetpadhiar4 left a comment

nnamdixobi commented Mar 8, 2024

psharma1984 left a comment

hetvi11110 left a comment

Tiantian-C left a comment

Abi-Liu left a comment •

edited

Loading

Abi-Liu Mar 13, 2024

peterson337 Mar 13, 2024

peterson337 commented Mar 13, 2024

Abi-Liu left a comment

Abi-Liu Mar 13, 2024 •

edited

Loading

peterson337 Mar 14, 2024

Abi-Liu Mar 15, 2024 •

edited

Loading

SanketKaware commented Mar 15, 2024

Abi-Liu left a comment

20chen-7 left a comment

SRamen1999 left a comment •

edited

Loading

rajnada commented Mar 16, 2024

PratimaSingh02 left a comment

sameersdeshpande left a comment

iven-yao left a comment •

edited

Loading

ImzIssa left a comment

ImzIssa Mar 17, 2024

mohabbasd left a comment

Coops023 left a comment

anandsesha commented Mar 24, 2024

Sarthak32 left a comment

Jaiwin-4998 left a comment

kylepham left a comment

rajnada commented Mar 30, 2024

MQChen211 commented Apr 3, 2024

aaryaneil left a comment

one-community commented Apr 29, 2024

one-community commented May 1, 2024

Peterson_Fix_Weekly_Summaries_edit_Last_week #2023

Peterson_Fix_Weekly_Summaries_edit_Last_week #2023

Conversation

peterson337 commented Mar 4, 2024

Description

priority Medium

Related PRS (if any):

Main changes explained:

How to test:

Screenshots or videos of changes:

Note:

meetpadhiar4 left a comment

Choose a reason for hiding this comment

nnamdixobi commented Mar 8, 2024

psharma1984 left a comment

Choose a reason for hiding this comment

hetvi11110 left a comment

Choose a reason for hiding this comment

Tiantian-C left a comment

Choose a reason for hiding this comment

Abi-Liu left a comment • edited Loading

Choose a reason for hiding this comment

Abi-Liu Mar 13, 2024

Choose a reason for hiding this comment

peterson337 Mar 13, 2024

Choose a reason for hiding this comment

peterson337 commented Mar 13, 2024

Abi-Liu left a comment

Choose a reason for hiding this comment

Abi-Liu Mar 13, 2024 • edited Loading

Choose a reason for hiding this comment

peterson337 Mar 14, 2024

Choose a reason for hiding this comment

Abi-Liu Mar 15, 2024 • edited Loading

Choose a reason for hiding this comment

SanketKaware commented Mar 15, 2024

Abi-Liu left a comment

Choose a reason for hiding this comment

20chen-7 left a comment

Choose a reason for hiding this comment

SRamen1999 left a comment • edited Loading

Choose a reason for hiding this comment

rajnada commented Mar 16, 2024

PratimaSingh02 left a comment

Choose a reason for hiding this comment

sameersdeshpande left a comment

Choose a reason for hiding this comment

iven-yao left a comment • edited Loading

Choose a reason for hiding this comment

ImzIssa left a comment

Choose a reason for hiding this comment

ImzIssa Mar 17, 2024

Choose a reason for hiding this comment

mohabbasd left a comment

Choose a reason for hiding this comment

Coops023 left a comment

Choose a reason for hiding this comment

anandsesha commented Mar 24, 2024

Sarthak32 left a comment

Choose a reason for hiding this comment

Jaiwin-4998 left a comment

Choose a reason for hiding this comment

kylepham left a comment

Choose a reason for hiding this comment

rajnada commented Mar 30, 2024

MQChen211 commented Apr 3, 2024

aaryaneil left a comment

Choose a reason for hiding this comment

one-community commented Apr 29, 2024

one-community commented May 1, 2024

Abi-Liu left a comment •

edited

Loading

Abi-Liu Mar 13, 2024 •

edited

Loading

Abi-Liu Mar 15, 2024 •

edited

Loading

SRamen1999 left a comment •

edited

Loading

iven-yao left a comment •

edited

Loading