Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peterson impl feature finish my team filter or tasks tab #2078

Conversation

peterson337
Copy link
Contributor

@peterson337 peterson337 commented Mar 21, 2024

Description

The filter was created for administrators and owners. These users require the filter as they oversee all users listed in the Leaderboard and the Team Member Tasks tables, rendering all tools for reviewing user work useless.

Related PRS (if any):

None

Main changes explained:

The components 'Team Members' and 'Leaderboard' were modified to implement the filter.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. The filter is exclusively visible to administrators and owners; other users will not see the filter.
  4. Log in as an administrator or owner to verify the visibility of the filter. Log in as any other user to confirm its invisibility.
  5. to test this PR you need of two or more teams.
  6. If you need to create a team, click on 'Other Links' and select 'Teams.' Then, click on 'Create New Team' and enter the team name. Next, click the button within the 'Members' column to add yourself and other users.
    b
  7. go to dashboard→ Tasks
  8. Click on the filter and select any team, then click on the "My Team" button.
  9. After the table displays the team members, the 'My Team' button will change to the 'View All' button. When clicked, the table will display all users of the HGN software, and the 'My Team' button will reappear. Alternatively, you can select another team in the filter to display the 'My Team' button again.
  10. Verify the functionality of the filter with buttons for 1 day, 2 days, 3 days, and so forth.

Screenshots or videos of changes:

a

Note:

Before deleting a team, ensure all members are removed. If the team is deleted first, it may still appear in the filter.

SanketKaware
SanketKaware previously approved these changes Mar 22, 2024
Copy link

@SanketKaware SanketKaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed your steps as mentioned. Overall looks good.

It works as expected.

  1. When there was no team, I was unable to click on "My Team" on the dashboard.
  2. After adding the team and its members, I was able to select the team and switch between "My Team" and "View All".
  3. Worked for 1 day, 2 days, 3 days, and so forth.

Here is my video review for reference - 

Screen.Recording.2024-03-21.at.7.53.27.PM.mov

meetpadhiar4
meetpadhiar4 previously approved these changes Mar 22, 2024
Copy link

@meetpadhiar4 meetpadhiar4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I tested your PR and it is working as intended. Please refer the video attached.

PR.2078.mov

Abi-Liu
Abi-Liu previously approved these changes Mar 22, 2024
Copy link
Contributor

@Abi-Liu Abi-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes work as expected! I can toggle to view between my individual teams vs all users inside the leaderboard and Team member tasks section.

video1529686426.mp4

Copy link
Contributor

@abdel-lall abdel-lall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've encountered an issue with the filter functionality—it's not functioning as expected. Please refer to the images below.

Before selecting a team:
Screenshot 2024-03-22 213244

After selecting a team:
Screenshot 2024-03-22 213308

Additionally, the styling of the button below doesn't seem to be as it was before.
Before:
Screenshot 2024-03-22 213357
After:
Screenshot 2024-03-22 213340

@peterson337 peterson337 dismissed stale reviews from Abi-Liu, meetpadhiar4, and SanketKaware via 81f8cb7 March 23, 2024 20:51
Copy link
Contributor

@vishavk1992 vishavk1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR by following the instructions and it works as intended .
After adding the team and its members, I was able to select the team and switch between "My Team" and "View All".
Worked for 1 day, 2 days, 3 days, and so forth.

PR-2078.mp4

@peterson337 peterson337 removed the request for review from MQChen211 July 15, 2024 14:20
@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit 539f1ba into development Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.