-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peterson impl feature finish my team filter or tasks tab #2078
Peterson impl feature finish my team filter or tasks tab #2078
Conversation
…filter_or_Tasks_Tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have followed your steps as mentioned. Overall looks good.
It works as expected.
- When there was no team, I was unable to click on "My Team" on the dashboard.
- After adding the team and its members, I was able to select the team and switch between "My Team" and "View All".
- Worked for 1 day, 2 days, 3 days, and so forth.
Here is my video review for reference -
Screen.Recording.2024-03-21.at.7.53.27.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I tested your PR and it is working as intended. Please refer the video attached.
PR.2078.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes work as expected! I can toggle to view between my individual teams vs all users inside the leaderboard and Team member tasks section.
video1529686426.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…filter_or_Tasks_Tab
81f8cb7
…filter_or_Tasks_Tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this PR by following the instructions and it works as intended .
After adding the team and its members, I was able to select the team and switch between "My Team" and "View All".
Worked for 1 day, 2 days, 3 days, and so forth.
PR-2078.mp4
Thank you all, merging! |
Description
The filter was created for administrators and owners. These users require the filter as they oversee all users listed in the Leaderboard and the Team Member Tasks tables, rendering all tools for reviewing user work useless.
Related PRS (if any):
None
…
Main changes explained:
The components 'Team Members' and 'Leaderboard' were modified to implement the filter.
…
How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
Note:
Before deleting a team, ensure all members are removed. If the team is deleted first, it may still appear in the filter.