Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shengwei hotfix: Added permission control for team code and timelog entry #2097

Conversation

ptrpengdev
Copy link
Contributor

@ptrpengdev ptrpengdev commented Mar 29, 2024

Description

image

Related PRS (if any):

This frontend PR is related to the #2026 frontend PR.

Main changes explained:

  • Update file src/components/Timelog/TimeEntry.jsx for including new permission validations to edit Jae's account timelog/hours
  • Update filesrc/components/UserProfile/UserProfile.jsx for including new permission validations to edit Jae's account team code
  • Update file src/components/WeeklySummariesReport/FormattedReport.jsx for including new permission validations to edit Jae's account team code and related date.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as owner user.
  5. Test cases:
  • Users should not be able to update the tangible timelogs for "Jae related accounts" ([[email protected], [email protected], [email protected] ]) by editing the timelog section and logged time.
    • Search Jae's related account in the user management and get its user id from the url
    • View the account timelog page -> go to http://localhost:3000/timelog/USER_ID
    • Verify that the user cannot edit any timelog infromation
  • Users should not be able to update the Jae's account team code or related information using the Weekly Summaries Reports page
    • same as previous test
    • go to .../weeklysummariesreport and find Jae's related account
    • verify that the jae's account is not editable

Screenshots or videos of changes:

Note:

Include the information the reviewers need to know.

@ptrpengdev ptrpengdev force-pushed the shengwei_add_jae_account_edit_permission_for_timelog_and_timeoff branch from 966d139 to 726884d Compare April 17, 2024 02:22
@one-community one-community merged commit 82cb58a into development Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants