Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akshit finished for Sarthak project and team overview UI fixed #2123

Merged
merged 20 commits into from
Jul 20, 2024

Conversation

Sarthak32
Copy link
Member

@Sarthak32 Sarthak32 commented Apr 6, 2024

Description

Restores Gradient gradient coloring for the overview boxes in Teams and Projects.

Related PRS (if any):

It is not related to any.

Main changes explained:

  • Implements Gradient gradient coloring for overview boxes in Teams and Projects to improve UI aesthetics.

How to test:

  1. check into the current branch.
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as owner/admin user
  5. go to dashboard→ Other Links>Teams and dashboard→ Other Links>Projects
  6. You should be able to see those gradient colors and proper alignment like this :

Screenshots or videos of changes:

Screen.Recording.2024-07-19.at.8.37.38.PM.mov

Note:

N/A

one-community and others added 6 commits March 27, 2024 21:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Frontend Release to Main [3.38]
Revert "Frontend Release to Main [3.38]"
…093-development

Revert "Revert "Frontend Release to Main [3.38]""
@Sarthak32 Sarthak32 requested a review from migfernandes01 April 6, 2024 17:50
hbodgal
hbodgal previously approved these changes Apr 7, 2024
Copy link
Contributor

@hbodgal hbodgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as mentioned. Teams page and Projects page both have gradients visible.

image

linkhanthtel
linkhanthtel previously approved these changes Apr 7, 2024
Copy link

@linkhanthtel linkhanthtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those gradient colors in both Teams and Projects Pages look good. Nice work!

#2123 (Projects) #2123 (Teams)

Frontend Release to Main [3.41]
Revert "Frontend Release to Main [3.41]"
…132-development

Revert "Revert "Frontend Release to Main [3.41]""
@one-community one-community dismissed stale reviews from linkhanthtel and hbodgal April 12, 2024 02:06

The merge-base changed after approval.

one-community and others added 3 commits April 12, 2024 09:38
Frontend Release to Main [3.43]
Frontend Release to Main [3.44]
jennZhang93
jennZhang93 previously approved these changes Apr 18, 2024
Copy link
Contributor

@jennZhang93 jennZhang93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with owner account. The gradient looks good!

Note: I noticed a thin outline on the gradient outside. Not sure if this is expected.

Although there are console errors, I think it is a problem from other branches. Those two errors always show up.

Screenshot 2024-04-17 at 9 23 44 PM (2)

@Sarthak32 Sarthak32 dismissed jennZhang93’s stale review April 18, 2024 02:26

The merge-base changed after approval.

Copy link

@MohdShahzil29 MohdShahzil29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working fine
Screenshot from 2024-04-18 13-45-32

Frontend Release to Main [3.45]
Copy link

@SRamen1999 SRamen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to see the new gradient coloring for the overview boxes in Teams and Projects pages.

Screen Shot 2024-04-19 at 9 36 25 AM Screen Shot 2024-04-19 at 9 37 31 AM

aaryaneil
aaryaneil previously approved these changes Apr 20, 2024
Copy link
Contributor

@aaryaneil aaryaneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI changes work as expected and the gradient looks good. Great work.
Screenshot 2024-04-20 at 5 56 44 AM
Screenshot 2024-04-20 at 5 56 53 AM

@Sarthak32 Sarthak32 dismissed aaryaneil’s stale review April 20, 2024 10:57

The merge-base changed after approval.

Tiantian-C
Tiantian-C previously approved these changes Apr 20, 2024
Copy link

@Tiantian-C Tiantian-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice!
Screenshot 2024-04-20 at 4 01 16 PM
Screenshot 2024-04-20 at 4 01 47 PM

@Sarthak32 Sarthak32 dismissed Tiantian-C’s stale review April 20, 2024 23:02

The merge-base changed after approval.

Copy link
Contributor

@dkn6 dkn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for the great work!

#2123

Sandhya1236
Sandhya1236 previously approved these changes May 28, 2024
Copy link

@Sandhya1236 Sandhya1236 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes successfully by checking out the current branch, running npm install, and npm run start:local to set up the PR locally. After clearing site data and cache, I logged in as an owner user and navigated to dashboard → Other Links → Teams and dashboard → Other Links → Projects. I verified that the gradient colors and proper alignment are displayed as expected. All functionalities worked as intended, and the feature appears stable. The PR is ready for merging.

image

@KurtisIvey KurtisIvey requested a review from aaryaneil June 1, 2024 18:40
@one-community one-community added Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. do not review Do not review or look at code without full context labels Jul 18, 2024
akshit0211 and others added 2 commits July 19, 2024 18:11
@akshit0211 akshit0211 added medium priority and removed Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. do not review Do not review or look at code without full context labels Jul 20, 2024
@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jul 20, 2024
@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit 860d2e8 into development Jul 20, 2024
1 check passed
@one-community one-community changed the title Sarthak project and team overview UI fixed Akshit finished for Sarthak project and team overview UI fixed Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet