-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peterson impl make profile team code field show existing codes #2191
Peterson impl make profile team code field show existing codes #2191
Conversation
…Field_Show_Existing_Codes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed your PR and everything worked as expected! Nice work!
2191.mov
…Field_Show_Existing_Codes
…g_Codes' of https://github.com/OneCommunityGlobal/HighestGoodNetworkApp into Peterson_Impl_Make_Profile_Team_Code_Field_Show_Existing_Codes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…Field_Show_Existing_Codes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…Field_Show_Existing_Codes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I reviewed your PR and it is working as intended. Please refer the video attached.
PR.2191.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this team code suggestion feature! I followed your testing instructions and was able to successfully:
Test input field:
- The dropdown appeared with a spinner as expected.
- Team codes loaded correctly and the spinner disappeared.
- Closing the dropdown by clicking outside worked as intended.
Select and search:
- Clicking on a code in the dropdown successfully added it.
- Typing in the input filtered the suggestions effectively.
Save changes: - After adding a new code, clicking "Save Changes" correctly assigned it to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- check into current branch
- Do npm install and npm start to run this PR locally
- Log in as an administrator or owner
- Go to View Profile→ Teams
- Assign and changed team codes.
This works good. Great work!
PR.2191.mp4
…Field_Show_Existing_Codes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…Field_Show_Existing_Codes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. I'd like this to suggest/show as many as possible so I rarely have to scroll. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this PR using an admin account. The dropdown spinner works as expected. After selecting a team code, the spinner disappears. I was able to assign a team code by selecting a team and a message popped up. After clicking the save changes button, another message popped which said the update was saved. Below is the video.
Screen.Recording.2024-07-05.205018.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I have reviewed PR 2191 using the following steps:
Checkout branch "Peterson_Impl_Make_Profile_Team_Code_Field_Show_Existing_Codes"
npm install
npm run start:local
Logged in as admin
View Profile -> Teams
Used the scroll bar to select a team code
Saved changes as well.
Screen.Recording.2024-07-11.at.10.34.40.AM.mov
The functionality described works as expected. Great work. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this PR and it works as expected and i was able to assign team code.
PR-2191.mp4
works as expected, well done! week8_1.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…Field_Show_Existing_Codes
2a5fa19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the PR #2191, and it worked as expected.
https://www.loom.com/share/25be1f844e6a4bea87c3cb92401b0933
dca90bc
Thank you all, merging! |
Description
This feature is designed to assist the administrator or owner in assigning a team code to a specific user by providing suggestions for codes in use.
Related PRS (if any):
None
…
Main changes explained:
The user profile file has been updated to retrieve the team codes from the database.
The Auto Complete Team Code component is designed to provide automatic suggestions in the input field.
…
How to test:
npm install
andnpm start
to run this PR locally8.After adding a new code for the user, click the "Save changes" button to assign the team code to the new user.
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.