Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peterson impl make profile team code field show existing codes #2191

Conversation

peterson337
Copy link
Contributor

@peterson337 peterson337 commented Apr 24, 2024

Description

This feature is designed to assist the administrator or owner in assigning a team code to a specific user by providing suggestions for codes in use.

Related PRS (if any):

None

Main changes explained:

The user profile file has been updated to retrieve the team codes from the database.

The Auto Complete Team Code component is designed to provide automatic suggestions in the input field.

How to test:

  1. check into current branch
  2. do npm install and npm start to run this PR locally
  3. Log in as an administrator or owner
  4. go to View Profile→ Teams
  5. Click on the input field, and a dropdown menu will appear with a spinning spinner. Once the team codes are loaded, the spinner will disappear, and the codes will be displayed. You can close the dropdown menu by clicking outside of it.
  6. Once the dropdown menu is open, click on the code or type in the input to find a specific code.
    8.After adding a new code for the user, click the "Save changes" button to assign the team code to the new user.

Screenshots or videos of changes:

a

Note:

Include the information the reviewers need to know.

linkhanthtel
linkhanthtel previously approved these changes Apr 25, 2024
Copy link

@linkhanthtel linkhanthtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed your PR and everything worked as expected! Nice work!

2191.mov

hbodgal
hbodgal previously approved these changes Apr 26, 2024
Copy link
Contributor

@hbodgal hbodgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I was able to see loading spinner and a dropdown with all codes. And even search and filter options. Everything works as required.

MinSun0814
MinSun0814 previously approved these changes May 2, 2024
Copy link

@MinSun0814 MinSun0814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now a dropdown with suggested input. Works as intended.
image
image

meetpadhiar4
meetpadhiar4 previously approved these changes May 8, 2024
Copy link

@meetpadhiar4 meetpadhiar4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I reviewed your PR and it is working as intended. Please refer the video attached.

PR.2191.mov

peter6866
peter6866 previously approved these changes Jun 2, 2024
Copy link
Contributor

@peter6866 peter6866 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this team code suggestion feature! I followed your testing instructions and was able to successfully:

Test input field:

  • The dropdown appeared with a spinner as expected.
  • Team codes loaded correctly and the spinner disappeared.
  • Closing the dropdown by clicking outside worked as intended.

Select and search:

  • Clicking on a code in the dropdown successfully added it.
  • Typing in the input filtered the suggestions effectively.
    Save changes:
  • After adding a new code, clicking "Save Changes" correctly assigned it to the user.
image

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jun 5, 2024
JatinAgrawal94
JatinAgrawal94 previously approved these changes Jun 6, 2024
Copy link
Contributor

@JatinAgrawal94 JatinAgrawal94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. check into current branch
  2. Do npm install and npm start to run this PR locally
  3. Log in as an administrator or owner
  4. Go to View Profile→ Teams
  5. Assign and changed team codes.
    This works good. Great work!
PR.2191.mp4

@akshit0211
Copy link
Contributor

This feature is working properly. Good work!

img1 img2 img3 img4

akshit0211
akshit0211 previously approved these changes Jun 11, 2024
Copy link
Contributor

@Sudershhh Sudershhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality is working as expected, however the design does not seem to be consistent. Having a substantial gap between the table headers and the input dropdown field OR the dropdown options can have a higher z index to keep it on top, would be good.

PR 2191

Sarath-3119
Sarath-3119 previously approved these changes Jun 28, 2024
Copy link

@Sarath-3119 Sarath-3119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR, on clicking the input, searched for a team code from the dropdown, when the right format is entered the drop down filtered based on the search result . ABle to save changes as expected.

image
image

@one-community
Copy link
Member

The functionality is working as expected, however the design does not seem to be consistent. Having a substantial gap between the table headers and the input dropdown field OR the dropdown options can have a higher z index to keep it on top, would be good.

PR 2191

Yes, I agree. I'd like this to suggest/show as many as possible so I rarely have to scroll.

Copy link

@Vigneshwar-Muriki Vigneshwar-Muriki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR using an admin account. The dropdown spinner works as expected. After selecting a team code, the spinner disappears. I was able to assign a team code by selecting a team and a message popped up. After clicking the save changes button, another message popped which said the update was saved. Below is the video.

Screen.Recording.2024-07-05.205018.mp4

Shadhrush5
Shadhrush5 previously approved these changes Jul 11, 2024
Copy link
Contributor

@Shadhrush5 Shadhrush5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have reviewed PR 2191 using the following steps:
Checkout branch "Peterson_Impl_Make_Profile_Team_Code_Field_Show_Existing_Codes"
npm install
npm run start:local
Logged in as admin
View Profile -> Teams
Used the scroll bar to select a team code
Saved changes as well.

Screen.Recording.2024-07-11.at.10.34.40.AM.mov

The functionality described works as expected. Great work. Thank you.

vishavk1992
vishavk1992 previously approved these changes Jul 11, 2024
Copy link
Contributor

@vishavk1992 vishavk1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR and it works as expected and i was able to assign team code.

PR-2191.mp4

@ZhangPeizhou
Copy link
Contributor

works as expected, well done!

week8_1.mp4

AnujVakil
AnujVakil previously approved these changes Jul 14, 2024
Copy link

@AnujVakil AnujVakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR and working as expected.
PR #2191_1
PR #2191_2

Copy link

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and everything works as expected.
Screenshot (109)
Screenshot (112)
Screenshot (110)
Screenshot (111)

SaiLavanya1
SaiLavanya1 previously approved these changes Jul 18, 2024
Copy link

@SaiLavanya1 SaiLavanya1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the PR #2191, and it worked as expected.
https://www.loom.com/share/25be1f844e6a4bea87c3cb92401b0933

@peterson337 peterson337 dismissed stale reviews from SaiLavanya1 and nikhilpittala16 via dca90bc July 18, 2024 22:40
@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit 65cf3e5 into development Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.