Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiral fix profile page formatting #2225

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

hiralsonip
Copy link
Contributor

@hiralsonip hiralsonip commented May 4, 2024

Description

Fix the design issue of the profile page

Related PRS (if any):

This frontend PR is related to the Development backend PR.

Main changes explained:

  • Fix the design issue in the Basic Information tab on the profile page
  • Update the design for the team tab when no team is assigned

How to test:

  1. check into the current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log in as an admin user
  5. go to dashboard→ Profile
  6. verify the design for the regular screen and check for the responsiveness as well.
  7. go to dashboard→ Profile → Team → Assign Team and check for the background colour in the dropdown menu
  8. go to dashboard→ Profile → Project → Assign Project and check for the background colour in the dropdown menu

Screenshots or videos of changes:

Before

Profile_Page_Basic_Info_Before Team_Assigned_Before Team_Not_Assigned_Before Assign_team_before

After

Profile_Page_Basic_Information Profile_Page_Team_Assigned Profile_Page_Team_Not_Assigned Assign_Project Assign_Team

Video

Profile_Page_Formatting.mp4

@lacnoskillz lacnoskillz self-requested a review May 4, 2024 17:13
lacnoskillz
lacnoskillz previously approved these changes May 4, 2024
Copy link
Contributor

@lacnoskillz lacnoskillz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hiralsonip
I pulled your code and revied your changes and they look great!
Nice work and good eye for detail. little things like this really help the page appear more professional and clean.

See below images

Profile page Before

profile before

Profile page after

profile after

Teams section before

profile teams section before

Teams section after

profile teams section after

Also maintained its mobile responsiveness!

profile after mobile profile teams section mobile after

Great work
and happy coding!

Copy link
Contributor

@hbodgal hbodgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HGN.APP.-.Google.Chrome.2024-05-04.12-47-38.mp4

I have double checked that I have checked in this branch locally and in development branch in backend. I have installed dependencies as well. I have used Admin login still I see white screen in profile page.

@hiralsonip
Copy link
Contributor Author

HGN.APP.-.Google.Chrome.2024-05-04.12-47-38.mp4
I have double checked that I have checked in this branch locally and in development branch in backend. I have installed dependencies as well. I have used Admin login still I see white screen in profile page.

Hi @hbodgal

I have applied these steps and it worked for me. Kindly check.

Copy link

@SushmithaPrathap SushmithaPrathap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hiral, I just reviewed this PR. The changes looks good! Its responsive as well!

Screen.Recording.2024-04-26.at.4.09.08.PM.mov

@hiralsonip hiralsonip dismissed stale reviews from SushmithaPrathap and lacnoskillz via bfbeae1 May 7, 2024 19:08
linkhanthtel
linkhanthtel previously approved these changes May 8, 2024
Copy link

@linkhanthtel linkhanthtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed your PR and new UI look good and responsive! Nice work!

2225.mov

Ramaruva
Ramaruva previously approved these changes May 9, 2024
Copy link
Contributor

@Ramaruva Ramaruva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi verified your changes in my local env and they are working as expected

hiralprofileformating.mp4

MinSun0814
MinSun0814 previously approved these changes May 9, 2024
Copy link

@MinSun0814 MinSun0814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New UI design looks clean and is responsive! Good work!
image
image

@KaushikMreddy
Copy link
Contributor

Hi,

I've reviewed your changes, they look good. The drop-downs look uniform and profile page is neater
image
image
image

Same pages after decreasing resolution
image
image

Good work!

Copy link
Contributor

@dkn6 dkn6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work! LGTM

1 2 3 4 5

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label May 30, 2024
@ZhangPeizhou
Copy link
Contributor

ZhangPeizhou commented May 31, 2024

Works as expected.

PR.2225.mp4

@hiralsonip hiralsonip requested a review from hbodgal May 31, 2024 16:40
CloudyZ524
CloudyZ524 previously approved these changes Jun 1, 2024
Copy link

@CloudyZ524 CloudyZ524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hiral, I just reviewed this PR which function works well and the page is responsive!

There are one suggestion: The box next to the Assign Team button with "X-XXX" looks confusing and I'm not sure if it has any function related to team assignment. It would be better to make it more clear with instructions and placeholders.

Screenshot 2024-05-31 at 13 42 34

mohabbasd
mohabbasd previously approved these changes Jun 2, 2024
Copy link
Contributor

@mohabbasd mohabbasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I tested your PR and it works as intended. Great Job! Below is a video for your reference.

Screen.Recording.2024-06-01.at.9.25.23.PM.mov

JatinAgrawal94
JatinAgrawal94 previously approved these changes Jun 2, 2024
Copy link
Contributor

@JatinAgrawal94 JatinAgrawal94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1)checked into the current branch
2)Executed npm install and npm run start:local to run this PR locally
3) Clear site data/cache
4) log in as an admin user

The profile page looks great and is responsive.
Screenshot 2024-06-01 at 8 13 12 PM
Screenshot 2024-06-01 at 8 13 23 PM
Screenshot 2024-06-01 at 8 13 41 PM
Screenshot 2024-06-01 at 8 13 52 PM

@akshit0211
Copy link
Contributor

Hello Hiral, I reviewed your changes and they look good.

Basic information Basic Dark mode Team Team Dark mode Assign project Responsive

Suggestion: Assign Project and Team drop-down windows should follow the dark mode color scheme.

Assign project - should be correct in dark mode Assign team - should be correct in dark mode

akshit0211
akshit0211 previously approved these changes Jun 6, 2024
@nishithaShetty
Copy link

Hi Nice work,
The design is rendered as expected, attached the screenshots below. They are responsive as well.
PR#2225_1
PR#2225_2
PR#2225_3
PR#2225_4
PR#2225_5

hbodgal
hbodgal previously approved these changes Jun 7, 2024
Copy link

@Trip2310 Trip2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this PR with development backend; In Project and Team , assign project and assign team is not visible for me other than that it works smooth.
a) At light and dark mode
b) checked page responsiveness for different dimensions(phone/desktop)
great work

2PR#2225 PR#2225

Copy link
Contributor

@suaniii suaniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified your changes in my local environment, and they are working as expected. The new UI looks clean, responsive, and uniform. Nice work!

Screen.Recording.2024-06-19.at.5.43.11.PM.mov

Copy link
Contributor

@Sudershhh Sudershhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Profile Page including the Teams and Projects Modals are responsive for different viewports. The UI is clean and seamless. Good Work.

PR 2225 - 2

PR 2225

Copy link
Contributor

@vishavk1992 vishavk1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hiral, I've tested your pull request. It works as intended. The profile page looks great and is responsive.

PR-2225
PR-2225-1

PR-2225-2.mp4

Copy link
Contributor

@DiyaWadhwani DiyaWadhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Hiral,
Went over your changes in both desktop and mobile versions and the UI looks clean and organized. Deletion of a team or project maintains the UI tables and assignment of either adds to the table properly without messing with the overall structure of the UI.
Added a video of testing below. Great work.

2225.mp4

Copy link

@Sarath-3119 Sarath-3119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes requested in the pr seems to be working properly. Checked the subsections in the profile page in both light and dark modes. The page formatting is seen as expected and the app entirely is responsive as well. Good work!

https://www.loom.com/share/307fc951f7f14505a5d1f7d597493657?sid=3859076c-27d4-40f3-87ce-b37ca91b7c50

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit 2533dd0 into development Jun 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.