-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hiral fix profile page formatting #2225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @hiralsonip
I pulled your code and revied your changes and they look great!
Nice work and good eye for detail. little things like this really help the page appear more professional and clean.
See below images
Profile page Before
Profile page after
Teams section before
Teams section after
Also maintained its mobile responsiveness!
Great work
and happy coding!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HGN.APP.-.Google.Chrome.2024-05-04.12-47-38.mp4
I have double checked that I have checked in this branch locally and in development branch in backend. I have installed dependencies as well. I have used Admin login still I see white screen in profile page.
Hi @hbodgal I have applied these steps and it worked for me. Kindly check.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Hiral, I just reviewed this PR. The changes looks good! Its responsive as well!
Screen.Recording.2024-04-26.at.4.09.08.PM.mov
bfbeae1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed your PR and new UI look good and responsive! Nice work!
2225.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi verified your changes in my local env and they are working as expected
hiralprofileformating.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. PR.2225.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Hiral, I just reviewed this PR which function works well and the page is responsive!
There are one suggestion: The box next to the Assign Team button with "X-XXX" looks confusing and I'm not sure if it has any function related to team assignment. It would be better to make it more clear with instructions and placeholders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I tested your PR and it works as intended. Great Job! Below is a video for your reference.
Screen.Recording.2024-06-01.at.9.25.23.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e53166d
bfbeae1
to
e53166d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified your changes in my local environment, and they are working as expected. The new UI looks clean, responsive, and uniform. Nice work!
Screen.Recording.2024-06-19.at.5.43.11.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Hiral,
Went over your changes in both desktop and mobile versions and the UI looks clean and organized. Deletion of a team or project maintains the UI tables and assignment of either adds to the table properly without messing with the overall structure of the UI.
Added a video of testing below. Great work.
2225.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes requested in the pr seems to be working properly. Checked the subsections in the profile page in both light and dark modes. The page formatting is seen as expected and the app entirely is responsive as well. Good work!
https://www.loom.com/share/307fc951f7f14505a5d1f7d597493657?sid=3859076c-27d4-40f3-87ce-b37ca91b7c50
Thank you all, merging! |
Description
Fix the design issue of the profile page
Related PRS (if any):
This frontend PR is related to the Development backend PR.
Main changes explained:
How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
Before
After
Video
Profile_Page_Formatting.mp4