Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carlos add hours by team member visualization project reports #2310

Conversation

cgomezhub
Copy link
Contributor

@cgomezhub cgomezhub commented May 31, 2024

(PRIORITY HIGH) Jae: Add “Hours by Team Member” Visualization to the Projects Reports page (WIP Carlos)

Related PRS (if any):

Previous PR1960
This current PR2310 is related to Backend #PR972

Description

The graph currently displays weekly committed hours by project member. However, it does not show the actual hours worked by member on each project.

Main changes explained:

  • in getTimeEntriesForSpecifiedProjectadd, add firstName lastName and isActive properties in 'TimeEntry' Schema from 'userProfile' Schema with will be received in the fronted.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as Owner, manager or admin user
  5. Go to dashboard => report => type the project => PieChart => pick the charts.
  6. check and test the pie charts as required

Note:

  1. You must add a project for at least one user ( set as a poject member)
  2. You must log hours for this member(s) in this project.
  3. Go to dashboard => report => type the project => PieChart => pick the charts
    4.See videos bellow for more info.

Requested job:

task

video before the change:

https://www.loom.com/share/7be14c4aec464c5fbb9669a11c4d63b5?sid=586d7ba2-8f94-4a4a-99e6-6725b31d4236

video after the change:

https://www.loom.com/share/478133a664ff48cd832d86abdef3edd4?sid=3222bf49-79f9-4fd8-b1d8-abe4bb0687b2

video after the change (toggle type)

https://www.loom.com/share/b4c44576df94464996eb0ef2321c4528?sid=7a1ebf85-e192-451a-b39b-1de04a6cb891

Note:

  1. You must add a project for at least one user ( set as a poject member)
  2. You must log hours for this member(s) in this project.
  3. Go to dashboard => report => type the project => PieChart => pick the charts
    4.See videos above for more info

Sandhya1236
Sandhya1236 previously approved these changes Jun 1, 2024
Copy link

@Sandhya1236 Sandhya1236 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have successfully tested the implementation of the "Hours by Team Member" visualization on the Projects Reports page. The main changes involved adding the firstName, lastName, and isActive properties to the TimeEntry schema from the userProfile schema, ensuring this data is available in the frontend. After checking into the current branch and running npm install, I cleared the site data and cache. Logged in as an Owner, Manager, or Admin user, I navigated to the dashboard, accessed the Reports section, selected a project, and viewed the PieChart. The pie charts correctly displayed the required information. Additionally, I ensured that projects had members with logged hours, verifying that the visualization worked as expected. The functionality performed seamlessly, reflecting the correct hours by team members on each project.

HGN.APP.-.Google.Chrome.2024-05-31.19-24-40.mp4

peter6866
peter6866 previously approved these changes Jun 1, 2024
Copy link
Contributor

@peter6866 peter6866 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on implementing the "Hours by Team Member" visualization feature for the Projects Reports page!
Here's the review based on the provided testing steps:

✅ Visualization Implementation:

  • Logged in as an Owner, manager, or admin user and navigated to the Projects Reports page (Dashboard => Reports => Type the project => PieChart => Pick the charts).
  • Tested the newly added "Hours by Team Member" visualization and confirmed that it displays the actual hours worked by each team member on the selected project.

✅ Data Prerequisites:

  • Acknowledged the provided notes and prerequisites for testing the feature effectively:
    1. Added at least one project with assigned team members.
    2. Logged hours for the assigned team members in the respective project.
  • Verified that the visualization accurately reflects the logged hours for the team members within the specified project.

✅ Visual Representation:

  • Reviewed the provided videos for additional information and guidance on testing the "Hours by Team Member" visualization.
  • Confirmed that the visual representation of the data aligns with the expected behavior and requirements.

https://www.loom.com/share/27a21970cb8740cf8e8bdb264f535daa?sid=ed5b6f59-94e8-4788-9333-bc372fae1863

meetpadhiar4
meetpadhiar4 previously approved these changes Jun 1, 2024
Copy link

@meetpadhiar4 meetpadhiar4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I tested your PR and it works as intended. Please refer the screenshot attached.
Screenshot 2024-06-01 at 1 19 28 PM

Kavil-Jain-514
Kavil-Jain-514 previously approved these changes Jun 3, 2024
Copy link
Contributor

@Kavil-Jain-514 Kavil-Jain-514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality is working as expected.

image

Logeshwari-Renu
Logeshwari-Renu previously approved these changes Jun 4, 2024
Copy link
Contributor

@Logeshwari-Renu Logeshwari-Renu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and verified the correct data visualization of "Hours by Team Member" in the project. The chart can be easily toggled to view the Individual contribution in a project with total hours details in center. The active and Inactive members chart options can be easily viewed. The overall functionality works as intended.

PR2310
PR2310_pic2

@cgomezhub cgomezhub requested review from Weiyao-Li, 20chen-7 and hbodgal and removed request for Trip2310 June 21, 2024 15:18
Copy link
Contributor

@Logeshwari-Renu Logeshwari-Renu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the PR and checked the "Hours by Team Member" visualization in the project. The chart lets you switch views to see each person's contribution and total hours in the center. You can easily see charts for active and inactive members. Everything works as expected.

2310

Copy link
Contributor

@shradac shradac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected now! Thanks for fixing it.

Copy link
Contributor

@deepthikannan deepthikannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Tested your PR, it's fixed and working as expected.

Copy link
Contributor

@vishavk1992 vishavk1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR it works as expected.
PR-2310+972

Copy link

@Sandhya1236 Sandhya1236 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have successfully tested the implementation of the "Hours by Team Member" visualization on the Projects Reports page. The main changes involved adding the firstName, lastName, and isActive properties to the TimeEntry schema from the userProfile schema, ensuring this data is available in the frontend. After checking into the current branch and running npm install, I cleared the site data and cache. Logged in as an Owner, Manager, or Admin user, I navigated to the dashboard, accessed the Reports section, selected a project, and viewed the PieChart. The pie charts correctly displayed the required information. Additionally, I ensured that projects had members with logged hours, verifying that the visualization worked as expected. The functionality performed seamlessly, reflecting the correct hours by team members on each project.

HGN.APP.-.Google.Chrome.2024-05-31.19-24-40.mp4

@Trip2310 Trip2310 self-requested a review June 25, 2024 22:42
@sahithidhulipala9
Copy link

left a comment on backend PR 972

Copy link
Contributor

@Kavil-Jain-514 Kavil-Jain-514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR works great.

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit ddfbd47 into development Jun 26, 2024
1 check passed
@cgomezhub cgomezhub added do not review Do not review or look at code without full context and removed High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not review Do not review or look at code without full context
Projects
None yet
Development

Successfully merging this pull request may close these issues.