Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jiayu fix bug manual add lost volunteer time #2319

Merged

Conversation

peter6866
Copy link
Contributor

@peter6866 peter6866 commented Jun 5, 2024

Description

image

Related PRS (if any):

This frontend PR is related to backend PR# 977.

Main changes explained:

  • Updated src/actions/timeEntries.js to return the status code for deleting time entries.
  • Updated AddLostTime.jsx to fix the boolean checking logic and modify request body.
  • Updated EditHistoryModal.jsx to fix the boolean checking logic and update the request body.

How to test:

  1. check into current branch
  2. do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. log as owner user
  5. go to dashboard→ Reports→ Reports→ Add Lost time
  6. verify owner can successfully add lost time for Project, Person, and Team.
  7. verify owner can successfully edit and delete lost time for Project, Person, and Team.

Screenshots or videos of changes:

Before Changes

image image

After Changes

https://www.loom.com/share/df6c6c8043ad405088c3766672dec080?sid=e4b769b9-4c1a-4245-9f1e-735f2f9c4342

@peter6866 peter6866 requested review from Nahiyan-16 and AriaYu927 June 5, 2024 19:34
@Logeshwari-Renu Logeshwari-Renu self-requested a review June 11, 2024 15:51
Copy link
Contributor

@Logeshwari-Renu Logeshwari-Renu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR as owner and able to add the lost time for Project, Person and Team.
The owner can also edit and delete the lost time for Project, Person and Team.
The issue fix for manual add lost volunteer time is fixed for owner!.

Suggestion: Toaster message can be added to show user the success of add/ edit/ delete lost time.

PR2319.+.PR977.mp4

@akshit0211
Copy link
Contributor

I am able to add, edit, and delete "add lost time" for projects, person, and team. Good job!

project add project projectedit person add person person edit

Copy link
Contributor

@Kavil-Jain-514 Kavil-Jain-514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the PR, and the functionality works perfectly fine; I can add lost time for the project, people, and team.
image
image

However, sometimes the screen goes all white when I log in as owner.
image

Copy link

@tianyangL11 tianyangL11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can successfully add and delete lost time for team, project and user. Great job!
8a9f3bc6152950c2c49212a2aeee2d9
9305220a30642a6840422aeba7caf55
3f4c193b732bc8c9d706dfcaa2e38ea

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jun 21, 2024
Copy link
Contributor

@DiyaWadhwani DiyaWadhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jiayu,
Thank you for the clear instructions. This works as expected. Attached a video implementation of the feature working successfully.

977+2319.mp4

Copy link
Contributor

@pavanswaroopl pavanswaroopl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Great work, but I have observed while adding lost time for team, steps to reproduce:

Add lost time -> select team -> and type a new team name -> it will ask for create new team with the name you have given, while it doesn't make sense to add lost time for a team that has not been created, I'm not sure that option might be at a wrong place, correct me if I'm wrong. As this might not be related to the current PR, I'm approving this, but this should be addressed elsewhere. Thanks

Screen.Recording.2024-06-29.at.4.56.32.PM.mov
Screen.Recording.2024-06-29.at.4.58.04.PM.mov
Screen.Recording.2024-06-29.at.5.03.15.PM.mov
Screenshot 2024-06-29 at 5 03 03 PM

@peter6866
Copy link
Contributor Author

Hello,

Great work, but I have observed while adding lost time for team, steps to reproduce:

Add lost time -> select team -> and type a new team name -> it will ask for create new team with the name you have given, while it doesn't make sense to add lost time for a team that has not been created, I'm not sure that option might be at a wrong place, correct me if I'm wrong.

Screen.Recording.2024-06-29.at.4.56.32.PM.mov
Screen.Recording.2024-06-29.at.4.58.04.PM.mov
Screen.Recording.2024-06-29.at.5.03.15.PM.mov
Screenshot 2024-06-29 at 5 03 03 PM

Hi @pavanswaroopl , I believe this is not related to this PR.

Copy link
Contributor

@pavanswaroopl pavanswaroopl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an issue that might not be related to this PR, hence approving it.

Copy link
Contributor

@nyelmela nyelmela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the PR as owner and I can successfully add,delete,update lost time for project, person and team.Here is the video implementation of the related functionality

HGN.APP.-.Google.Chrome.2024-06-29.18-21-34.mp4

@peter6866 peter6866 requested a review from beblicarl June 30, 2024 20:10
@peter6866 peter6866 requested a review from Jingyii800 June 30, 2024 20:10
Copy link
Contributor

@vishavk1992 vishavk1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR with backend PR 977. i followed the instructions as given and successfully tested this PR . It working as expected and i was able to add, edit and delete the lost time for project, person and Team.

Suggestion :Toaster messages can be added to notify the user of successful additions, edits, or deletions of lost time.

PR-2319+977
PR-2319-1
PR-2319-2

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit 254f16c into development Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants