Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiwani TeamReport unit test #2324

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

Shiwani99
Copy link
Contributor

Description

Unit test for src/components/Reports/TeamReport/TeamReport.jsx

Main changes explained:

  • Added 18 test cases: renders without crashing, check if team not found message is displaying as expected when there are no teams, check if the team name is getting displayed when the team is present, check if the created date and its is getting displayed when the team is present, check if team ID header and its value is getting displayed when the team is present, check if Last updated header and its value is getting displayed when the team is present, check if Number of Members and its value is getting displayed as expected, check if Total Team Blue Squares, Weekly Committed Hours, Total Worked Hours This Week gets displayed as expected, check if Breakdown of Weekly Hours So Far This Week header gets displayed as expected, check Name, Created After, Modified After header displays as expected, check All, Team, Status header displays as expected, check Team Members, ID, Created At header displays as expected, check if date picker for Created After works as expected when the correct date is given, check if date picker for Created After gives updated date when invalid date is given, check Active checkbox works as expected when the box is checked, check Inactive checkbox works as expected when the box is checked, check if loading message is getting displayed when all teams is empty, check if Name input element is working as expected

How to test:

  1. check into current branch
  2. do npm test src/components/Reports/TeamReport/__tests__/TeamReport.test.js
  3. check if all the test cases passes without any errors or warnings

Screenshots or videos of changes:

Screenshot 2024-06-06 at 4 24 45 PM

@Changhao3220K
Copy link
Contributor

Hi @Shiwani99,
Nice work of the unit test, however on my end I could only see 11 tests for this unit test branch. Could you double check the unit test file?
屏幕快照 2024-06-06 下午10 32 24

@Vijeth-V
Copy link

Vijeth-V commented Jun 7, 2024

Hello,
Nice work on unit test. All 20 tests passed without any errors.
Screenshot 2024-06-06 at 10 44 16 PM

@Logeshwari-Renu Logeshwari-Renu self-requested a review June 7, 2024 21:48
Copy link
Contributor

@Logeshwari-Renu Logeshwari-Renu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the test cases have been passed!

PR2324

@Shiwani99
Copy link
Contributor Author

Hi @Shiwani99, Nice work of the unit test, however on my end I could only see 11 tests for this unit test branch. Could you double check the unit test file? 屏幕快照 2024-06-06 下午10 32 24

Hi,
Thank you for your review. It looks like you have executed the tests from the 1st commit I made because I added only the 11 test cases in my first commit. Can you try pulling the latest changes in the branch and try executing it again? because the latest commit has all the 20 test cases.

Copy link
Contributor

@deepthikannan deepthikannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
All unit test cases passed. Nice work !

Copy link

@tianyangL11 tianyangL11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and all test case passed
image

Copy link

@cecilia-uu cecilia-uu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

截屏2024-06-08 下午9 56 23 All tests passed!

Copy link
Contributor

@shradac shradac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
All tests passed!

week1-12

@iTvX
Copy link
Contributor

iTvX commented Jun 9, 2024

Good job, all tests pass

2024-06-09 at 11 34 09@2x

@beblicarl beblicarl self-requested a review June 14, 2024 06:44
@beblicarl
Copy link
Contributor

All test passed successfully

image

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit d413a16 into development Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.