-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nahiyan_Dark mode on dropdown items #2328
Nahiyan_Dark mode on dropdown items #2328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the drop down elements look dark in dark mode and light in light mode, just as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might come across as a stickler for this one, but i'm requesting changes for two reasons.
-
the "hello username" is in the same font color as the actual drop down selector links. It should be lighter or modified to a less intuitively interactive color as it is in light mode.
-
There's no reason to lighten the text as the hover color activates. Normally, text lightens in color when in dark mode and hovered upon. Just leave the text color as white, so the contrast ratio doesn't get worse at the very least.
46b0def
Changes look great. If you can clear up the merge conflict please and then shoot me a slack message once it's done, so I can review it again when I get off work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Dark mode is implemented on all dropdown items on the header
Related PRS (if any):
This frontend PR is related to the dev backend
How to test:
npm install
andnpm run start:local
to run this PR locallyScreenshots or videos of changes: