Peterson implement toast when user is already in a team

[peterson337]

Description

This PR has been opened to implement a toast notification that will be displayed when a user is added to a team they are already part of.

Related PRS (if any):

None
…

Main changes explained:

The component "AddTeamPopup.jsx" has been modified to implement the toast.
…

How to test:

1. Check into current branch
2. Do npm install and ... to run this PR locally
3. Clear site data/cache
4. Log in as an administrator or owner.
5. You need to add your user to a team to test this PR.
6. Go to view profile → Teams.
7. Click on the button named "Assign Team".
8. Select a team that your user has already been added to.
9. Click on the button named "Confirm" and check if the toast appears.

Screenshots or videos of changes:

Note:

None

[jennZhang93]

Tested with owner account and feature work as intended. When trying to add a user to an existing team, the error pop up will appear. Good work!

[shradac]

Verified team assignment functionality for an admin user.
Confirmed error toast notification appears when already in the same team. Good work!

[Logeshwari-Renu]

I have tested the PR as admin. Getting notification whenever try to add an already assigned team. Also the new team code is getting successfully added. The functionality works as intended.

[Kavil-Jain-514]

The functionality works when a new team is assigned to the user, and then the user is added to the same team again.

However, I am facing issues when the user is added again to the existing team. There is no response in the UI. Please check the video.

PR.2332.mp4

In the video, "The Test 2024" was the new team just added, while the "FanYangTestTeam" was the team the user was already in.

[KaushikMreddy]

Hi Peterson,

I found 2 test cases in this PR, I've shown them below.

1. Test case 1 :

• Find a team that a user is already assigned to
• Try adding yourself into the same team
• The warning shows up
• Here, I'm part of team 2023 and I try to add myself
  
• I get the warning
  
• Test case 1 works as expected

2. Test case 2 :

• Assign yourself a new team
• Click confirm
• The user is not added into that team until the user click save changes at the bottom of the page
• But the assign team modal stays open, This needs to be closed after the user clicks confirm.
• Since it stays open, if I click confirm again in the assign team modal, there is no response from the UI, nor is there any API call running.
• I clicked confirm here, got the team assigned but the modal stayed open
  
• Even if I keep clicking confirm after that, there is no response anywhere
  
• Test case 2 is the issue

This may be linked to the previous user's requested changes. Please verify and update. If this is not linked to your task, I can raise a bug.

[Kavil-Jain-514]

After your changes, I have reviewed the PR again. The problem I faced earlier was solved; I got the Toast error message for adding the user to an existing team. However, there is a new issue when I try to assign the user to a new team (which still needs to be added to the team list); I am facing errors. This was not the issue in my previous review. So your changes might have caused it.

I have attached the video for you to look over.

PR.2332-1.mp4

[tianyangL11]

It work as expected. Great job!

[aaryaneil]

Tested the PR and the changes work as expected and it won't let me add the user to the same team again.

[KaushikMreddy]

Hi Peterson,

I found 2 test cases in this PR, I've shown them below.

1. Test case 1 :

• Find a team that a user is already assigned to
• Try adding yourself into the same team
• The warning shows up
• Here, I'm part of team 2023 and I try to add myself
  
• I get the warning
  
• Test case 1 works as expected

2. Test case 2 :

• Assign yourself a new team
• Click confirm
• The user is not added into that team until the user click save changes at the bottom of the page
• But the assign team modal stays open, This needs to be closed after the user clicks confirm.
• Since it stays open, if I click confirm again in the assign team modal, there is no response from the UI, nor is there any API call running.
• I clicked confirm here, got the team assigned but the modal stayed open
  
• Even if I keep clicking confirm after that, there is no response anywhere
  
• Test case 2 is the issue

This may be linked to the previous user's requested changes. Please verify and update. If this is not linked to your task, I can raise a bug.

Hi Peterson,

Test case 2 works as well. Duplicate team cannot be added and that is shown clearly using toast messages. Good work.

[Kavil-Jain-514]

The functionality works as expected.
https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/assets/112303944/85a621ca-870e-4bd2-812b-25bd9e74a0be

[kabraambika]

I have reviewed the frontend PR with latest backend development branch. Feature is showing toast in case of existing team as shown below and working fine in dark mode on as well.

[ishan-miglani]

the functionality works correctly. I am able to see the toast when I try to add user in a team they are already in. Thanks!

Screen.Recording.2024-07-19.at.6.05.53.PM.mov

[angelalalacheng]

Hi,
I use your branch Peterson_Implement_toast_when_user_is_already_in_a_team for frontend and latest development branch for backend. The new feature works good!

[SrikanthChowdary495]

I have tested this PR. I tested with my account and the feature worked as intended. When trying to add a user to an existing team, the error pop-up will appear.

profile.mp4

[SaiLavanya1]

I tested the PR and observed that the toast notification works as expected. When trying to assign a user to a team they are already a part of, a toast notification appears indicating the user is already in the team. Additionally, when assigning the user to a new team, the confirmation toast displays successfully. The feature is functioning correctly, meeting the requirements outlined in the PR description.

[Pranay-ai]

Hey @peterson337
The PR is Working as Expected
Here is The screenshot

Thank You

[souravwalke]

I tested the PR and observed that the toast notification works as expected.

https://www.loom.com/share/dac7a28bc40d48f0b7daa3cf29e0c502?sid=eb2e97cc-53cd-457a-844f-45bd1e86e67c

[Annezhang673]

Function works as expected. I'm unable to assign myself to a team I'm already in as an admin.

[Gmon-k]

I have tested from side and it is working as expected.

[varunreddy03]

I have tested this PR in owner account and this PR works as intended and I have also tested this even in dark mode, all the colors are vibrant and visible clearly. Great work!

[arunsrao9]

Tested with owner account and feature work as intended. When trying to add a user to an existing team, the error pop up will appear. Good work!

[one-community]

Thank you all, merging!