-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nathalia make blue square description box bigger and auto-fit #2333
Nathalia make blue square description box bigger and auto-fit #2333
Conversation
…ies to the summary inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -142,6 +143,11 @@ const UserProfileModal = props => { | |||
} | |||
} | |||
|
|||
const adjustTextareaHeight = (textarea) => { | |||
textarea.style.height = 'auto'; | |||
textarea.style.height = `${textarea.scrollHeight}px`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Nathalia,
Everything looks good in the codebase but I would like to highlight that you are simply overwriting the same property on line 147 and 148. It will be better to get rid of the line 147 as it serves no purpose here.
Please let me know if I have interpreted it wrongly.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all, merging! |
Description
Related PRS (if any):
This frontend PR is related to the dev backend PR.
Main changes explained:
How to test:
npm install
andnpm run start:local
to run this PR locally.Screenshots or videos of changes:
HGN.APP.-.Google.Chrome.2024-06-07.18-57-36.mp4
Note:
...