-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shengwei fix user profile quick setup #2339
Shengwei fix user profile quick setup #2339
Conversation
- Modify loadUserProfile function in UserProfile.jxs to include checkIsProjectsEqual() to reverify project differences in original profile and new profile after update is saved. - Add data validation in quick setup modal, ensuring no duplicate team/project data can be added before new team/project value assignment.
…retriving user profile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I tried testing this PR and ran into multiple issues,
- Please update the error message : Team Code Does not exist or not found
- Could also share some valid Team codes to test adding a new title
- While adding a new title, it gives me an error that says " invalid team code", but the confirm button is enabled. When I click the confirm button, the page crashes
Ideally the confirm button should be enabled until all the required fields are filled. - Please add an auto-fill list to pop up when any team code is being entered, just like how it is for the Team name
Please share video on the changes you've made to make it easier to follow along. I'd like to test more, but the team code is a blocker, please provide a dummy team code to test.
Thank you
…odNetworkApp into shengwei_fix_user_profile_quick_setup
…ectly displayed save changes message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even on selecting team names from the list , it shows team name not found. Please fix that.
PR.2339.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Great work, but I ran into some issues, firstly, can you please share some test values for 'add a new title option', and when I add a valid name in team assignment, it says team name doesn't exist. steps to reproduce:
Screen.Recording.2024-06-29.at.6.35.56.PM.mov
…odNetworkApp into shengwei_fix_user_profile_quick_setup
Sorry for the confusion. I had some local changes and forgot to push it to the remote branch. Please re-rest. I also attached a demo video for reference. video1508036184.mp4 |
Please re-test. I have pushed my latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran into a issue when assigning a team. Below video has all the details.
Untitled.video.-.Made.with.Clipchamp.2.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the steps to test the changes. As you can see in the below video I am getting a error saying that team name is not valid and also the team code is not auto populating like project assignment or team assignment once I start typing in the input field.
Please refer the video attached.
Screen.Recording.2024-07-12.at.10.41.57.PM.mov
Just found out that the issue was caused by the cache data in my local broswer. I have added the allTeamCode in the Team redux store as one of the initial states. I have re-tested the QSC feature in incognito mode. Please pull the latest frontend code in this PR and the backend PR 1028 .Thanks. |
Hi @vijay10pk Just found out that the issue was caused by the cache data in my local broswer. I have added the allTeamCode in the Team redux store as one of the initial states. I have re-tested the QSC feature in incognito mode. Please pull the latest frontend code in this PR and the backend PR 1028 .Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have thoroughly tested the current branch by performing npm install
and running the application locally. I cleared the site data/cache and logged in as an admin user. Using the quick setup modal in the user profile, I verified that no duplicate project/team entries are added. I also confirmed that deleting all project/team data and reapplying the quick setup configuration does not lead to a page crash. Data validation for the 'Add A New Title' form works as expected, including validation for team code, team name, and project fields. The 'Add A New Title' functionality successfully saves a new quick setup configuration. Additionally, no warning message of 'please click on save changes…' is displayed after saving new information using the quick setup modal. All features are functioning perfectly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
When testing the user profile quick setup modal, I encountered an error stating "Team Name Not Exists" when entering a team name. This error appears regardless of the input, indicating a validation issue with the team name. The error prevents the assignment of team and project data to the user profile. Please review the team name validation logic to resolve this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ReinaT5678 and @SaiLavanya1 , I just pulled the code from this branch and re-tested the feature without any modification. I was not able to reproduce the issue mentioned in the previous comments. Video attached. Frontend: #2339 video1475343734.mp4 |
Not able to reproduce the issue.
Thank you all, merging! |
Description
Related PRS (if any):
This frontend PR is related to the #1028 backend PR.
…
Main changes explained:
How to test:
npm install
and...
to run this PR locallyVerify that after deleting all project/team data, using the existing quick setup configuration and applying changes will not lead to a page crash.
Verify that data validation of 'Add A New TItlte' form is working. E.g. Team code, team name, and project validation should work as expected.
Verify that 'Add A New Title' is working as expected by saving a new quick setup config.
Verify that after saving new info with use of quick setup modal, no warning message of 'please click on save changes…' displayed
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.