Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nahiyan_Optimized permissions management page for mobile displays #2446

Merged

Conversation

Nahiyan-16
Copy link
Contributor

Description

Optimized permissions management page for all viewports 375px wide and above.

Related PRS (if any):

This frontend PR is related to the dev backend

Main changes explained:

  • Redesigned pagination so it fits all viewports.
  • Added side-scrolling to the table
  • Added responsive font sizes.
  • Fixed permission item page as well

How to test:

  1. check into current branch
  2. do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. log as owner user
  5. go to dashboard→ Other Links -> Permissions Management
  6. verify that this page is functioning with no issues under all viewports 375px and above
  7. Click on a permission item
  8. verify that this page is functioning with no issues under all viewports 375px and above
  9. verify this new feature works in dark mode

Screenshots or videos of changes:

Screenshot 2024-07-11 164310
Screenshot 2024-07-11 164328
Screenshot 2024-07-11 164628

@Nahiyan-16 Nahiyan-16 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jul 11, 2024
Copy link

@AnujVakil AnujVakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR in light and dark mode. Everything looks fine but for the mobile displays, info section icon for Save and Delete Role button is not visible.

Screen Shot 2024-07-11 at 2 15 04 PM

It is visible in normal window view.
Screen Shot 2024-07-11 at 2 14 04 PM

nyelmela
nyelmela previously approved these changes Jul 11, 2024
Copy link
Contributor

@nyelmela nyelmela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR, and everything works perfectly well. I checked into the current branch, ran npm install, and npm run start:local to run the PR locally. After clearing the site data and cache, I logged in as the owner user and navigated to the dashboard → Other Links → Permissions Management. I verified that this page functions without any issues under all viewports 375px and above. Additionally, I clicked on a permission item and confirmed that the page continued to function correctly under all viewports 375px and above. Lastly, I ensured that this new feature works seamlessly in dark mode. Everything worked as expected.

image

image

@Nahiyan-16
Copy link
Contributor Author

@AnujVakil You're not on the correct branch. Please retest this.

@Nahiyan-16 Nahiyan-16 requested a review from AnujVakil July 11, 2024 22:43
@angelalalacheng
Copy link
Contributor

angelalalacheng commented Jul 11, 2024

Hi Nahiyan-16,

I set the frontend branch as Nahiyan_Optimize-Permissions-Management-Page and backend branch as development. The page is functioning with no issues at viewports 375px in both light and dark mode and permission list works good as well.
Screenshot 2024-07-11 at 3 41 15 PM
Screenshot 2024-07-11 at 3 41 41 PM
Screenshot 2024-07-11 at 3 43 35 PM
Screenshot 2024-07-11 at 3 42 03 PM
Screenshot 2024-07-11 at 3 42 29 PM

vijay10pk
vijay10pk previously approved these changes Jul 11, 2024
Copy link
Contributor

@vijay10pk vijay10pk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes works as expected.

Screen.Recording.2024-07-11.at.7.48.00.PM.mov

AnujVakil
AnujVakil previously approved these changes Jul 11, 2024
Copy link

@AnujVakil AnujVakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-tested this PR on current branch and it is working fine.
Screen Shot 2024-07-11 at 4 52 06 PM

Copy link

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and everything works as expected for both light mode and dark mode.
Screenshot (74)
Screenshot (75)
Screenshot (76)
Screenshot (77)

SaiLavanya1
SaiLavanya1 previously approved these changes Jul 12, 2024
Copy link

@SaiLavanya1 SaiLavanya1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this PR and it is working fine.
https://www.loom.com/share/5cf1fc4ca43947b38165f6d4e8ca683f

kdaga81
kdaga81 previously approved these changes Jul 12, 2024
Copy link
Contributor

@kdaga81 kdaga81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

The changes are working as expected!

Copy link

@sahithidhulipala9 sahithidhulipala9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this feature, in all the above mentioned steps, feature working as expected.
PR 2446 1
PR 2446 2
PR 2446 3

rmcgummadi
rmcgummadi previously approved these changes Jul 12, 2024
Copy link

@rmcgummadi rmcgummadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have logged in as the local Admin User and tested Pull Request #2446. It is working as expected. I tested it in both dark mode and light mode with a viewport of 375px wide and above. The functionality is working as expected.

Screenshot 2024-07-12 at 9 33 20 AM

Screenshot 2024-07-12 at 9 34 47 AM

Copy link

@Vigneshwar-Muriki Vigneshwar-Muriki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR by logging in as an admin and verifying the feature on mobile displays and other viewports. All the buttons align correctly across all viewports. Additionally, when a permission item is clicked, the page functions properly on all viewports and in dark mode.

Frontend.PR.2446.mp4

@beblicarl beblicarl self-requested a review July 12, 2024 18:59
@beblicarl
Copy link
Contributor

This functionality works as intended and the code is great

image

image

beblicarl
beblicarl previously approved these changes Jul 12, 2024
vishavk1992
vishavk1992 previously approved these changes Jul 12, 2024
Copy link
Contributor

@vishavk1992 vishavk1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR and everything works as expected. Great Work!!!

PR-2446.mp4

Copy link

@Rishitha1309 Rishitha1309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR in both light mode and dark mode, everything works perfectly fine.

2446-1
2446-2
2446-3

aaryaneil
aaryaneil previously approved these changes Jul 13, 2024
Copy link
Contributor

@aaryaneil aaryaneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR for 375px for light and dark mode and the changes work as expected.
Screenshot 2024-07-12 at 9 11 24 PM
Screenshot 2024-07-12 at 9 11 40 PM
Screenshot 2024-07-12 at 9 12 57 PM
Screenshot 2024-07-12 at 9 13 22 PM

cecilia-uu
cecilia-uu previously approved these changes Jul 13, 2024
Copy link

@cecilia-uu cecilia-uu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

截屏2024-07-13 下午11 24 49 截屏2024-07-13 下午11 24 57 It works as expected!

Copy link
Contributor

@KaushikMreddy KaushikMreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nahiyan,

The Mobile layout looks good. Most of it works pretty well. I found a minor issue.

  1. In 390 px, The user name gets cut out if the drop-down in other links in opened.
    image
    This occurs in 430px as well
    image

everything else looks good!

MinSun0814
MinSun0814 previously approved these changes Jul 13, 2024
Copy link

@MinSun0814 MinSun0814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Screenshot 2024-07-13 at 16 55 14
Nothing looks overlapping. Nice work!

Shadhrush5
Shadhrush5 previously approved these changes Jul 15, 2024
Copy link
Contributor

@Shadhrush5 Shadhrush5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I reviewed PR #2446 by following the steps mentioned.
Checked out the branch "Nahiyan_Optimize-Permissions-Management-Page".
Ran the npm run start:loclal command
Logged in as owner -> Other Links -> Permission management

The page functions without any issues under all viewports 375px and above.

Screenshot 2024-07-15 at 10 18 32 AM

Additionally, I clicked on a permission item and confirmed that the page continued to function correctly under all viewports 375px and above.

Screenshot 2024-07-15 at 10 19 16 AM Screenshot 2024-07-15 at 10 19 32 AM

Everything works as expected. Thank you for the great work.

Copy link
Contributor

@JatinAgrawal94 JatinAgrawal94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At 375PX,
some delete buttons are going out of the viewport, please fix the alignment of the buttons.

pr2446.mp4

@Nahiyan-16
Copy link
Contributor Author

@KaushikMreddy The header is not solely part of the permission management page. It is its component and there is a PR handling this.

@Nahiyan-16 Nahiyan-16 requested a review from KaushikMreddy July 18, 2024 17:13
Copy link
Contributor

@Chetan0606 Chetan0606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the functionalities as per the provided steps and everything looks fine.
Screenshot (311)
Screenshot (310)
Screenshot (309)
Screenshot (308)

Copy link
Contributor

@SrikanthChowdary495 SrikanthChowdary495 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I logged in as the local Admin User and tested Pull Request #2446. Everything works as expected in both dark mode and light mode, with a viewport of 375px wide and above.
please find the video for reference.

mobile.display.mp4

@ReinaT5678
Copy link
Contributor

The Permissions Management page works as expected. I was able to test the functionality for both light and dark screens with viewports below and above 375px and both worked well. See screenshots below from when I was testing!

Screenshot 2024-07-20 at 3 02 17 PM Screenshot 2024-07-20 at 3 02 27 PM

Below are images from exploring the different pages within the permissions management page and testing different popups and buttons.

Screenshot 2024-07-20 at 3 04 33 PM Screenshot 2024-07-20 at 3 05 02 PM

ReinaT5678
ReinaT5678 previously approved these changes Jul 20, 2024
@one-community one-community removed the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jul 20, 2024
Copy link
Contributor

@pavanswaroopl pavanswaroopl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work,

Permissions management initial page works on all viewports fine, but not sure whether this is in this PR scope, buttons go out of view when width < 375px. after entering a role.

Screen.Recording.2024-07-20.at.9.00.51.PM.mov
Screen.Recording.2024-07-20.at.9.02.13.PM.mov
Screenshot 2024-07-20 at 9 03 19 PM

@one-community one-community merged commit 9e1f4ac into development Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.