-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nahiyan_Optimized permissions management page for mobile displays #2446
Nahiyan_Optimized permissions management page for mobile displays #2446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this PR, and everything works perfectly well. I checked into the current branch, ran npm install
, and npm run start:local
to run the PR locally. After clearing the site data and cache, I logged in as the owner user and navigated to the dashboard → Other Links → Permissions Management. I verified that this page functions without any issues under all viewports 375px and above. Additionally, I clicked on a permission item and confirmed that the page continued to function correctly under all viewports 375px and above. Lastly, I ensured that this new feature works seamlessly in dark mode. Everything worked as expected.
![image](https://private-user-images.githubusercontent.com/123037122/348013511-28d22f2d-7de9-4a6a-bafd-f563687a081c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MTY1ODIsIm5iZiI6MTczODkxNjI4MiwicGF0aCI6Ii8xMjMwMzcxMjIvMzQ4MDEzNTExLTI4ZDIyZjJkLTdkZTktNGE2YS1iYWZkLWY1NjM2ODdhMDgxYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwODE4MDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wMTJhZDIxNDE5NjgwMDZjNTM5NjYwYWUwY2I1NzM0MDI3NmM5MTYyNWQwOGI0MjUzYjRhN2M3OGU5Njk0MjE2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Za2oCRVQLyoOA-3stJnaijXtVIVrRTN7wZeWJdHuZss)
@AnujVakil You're not on the correct branch. Please retest this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes works as expected.
Screen.Recording.2024-07-11.at.7.48.00.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this PR and it is working fine.
https://www.loom.com/share/5cf1fc4ca43947b38165f6d4e8ca683f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have logged in as the local Admin User and tested Pull Request #2446. It is working as expected. I tested it in both dark mode and light mode with a viewport of 375px wide and above. The functionality is working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this PR by logging in as an admin and verifying the feature on mobile displays and other viewports. All the buttons align correctly across all viewports. Additionally, when a permission item is clicked, the page functions properly on all viewports and in dark mode.
Frontend.PR.2446.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this PR and everything works as expected. Great Work!!!
PR-2446.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I reviewed PR #2446 by following the steps mentioned.
Checked out the branch "Nahiyan_Optimize-Permissions-Management-Page".
Ran the npm run start:loclal command
Logged in as owner -> Other Links -> Permission management
The page functions without any issues under all viewports 375px and above.
![Screenshot 2024-07-15 at 10 18 32 AM](https://private-user-images.githubusercontent.com/119898772/348801459-d962fbd1-79cf-47b5-b240-dfef3f8dad68.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MTY1ODMsIm5iZiI6MTczODkxNjI4MywicGF0aCI6Ii8xMTk4OTg3NzIvMzQ4ODAxNDU5LWQ5NjJmYmQxLTc5Y2YtNDdiNS1iMjQwLWRmZWYzZjhkYWQ2OC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwODE4MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03OWZjODFiZjRmMjE2ZjZiNzdlNjU2NjFjMDM3ODhmM2IwOTdlMTA5YmFlYTczOGZhZjlhMmVmNGIwNzMyYWQwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.SjjrLy-emZeSFrJ6rL9Ji1LyKOzqq3BNf44nTQKhNec)
Additionally, I clicked on a permission item and confirmed that the page continued to function correctly under all viewports 375px and above.
![Screenshot 2024-07-15 at 10 19 16 AM](https://private-user-images.githubusercontent.com/119898772/348801535-91830fff-81a0-486e-ae45-7dee2a24dbe1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MTY1ODMsIm5iZiI6MTczODkxNjI4MywicGF0aCI6Ii8xMTk4OTg3NzIvMzQ4ODAxNTM1LTkxODMwZmZmLTgxYTAtNDg2ZS1hZTQ1LTdkZWUyYTI0ZGJlMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwODE4MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00YzhhMDI5NjU1NDUyZWVjYjUyYWQyMWM5NjI3MTI0ZjdlZTI1MGExZGQzMzEwODMzZDg1YzZhMmEwZWI2NzNiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.vgCN3PJXX-GAtbsEmlhG9VrAIjuV6v1p1tkAREqEACg)
![Screenshot 2024-07-15 at 10 19 32 AM](https://private-user-images.githubusercontent.com/119898772/348801543-822cd767-4828-4251-ab44-c214b216e62d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MTY1ODMsIm5iZiI6MTczODkxNjI4MywicGF0aCI6Ii8xMTk4OTg3NzIvMzQ4ODAxNTQzLTgyMmNkNzY3LTQ4MjgtNDI1MS1hYjQ0LWMyMTRiMjE2ZTYyZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QwODE4MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZjA3OTA1NDViYTE5ZDRmY2RkYmRlNTA2OWFhMDRmMjk4NmZkNDc4MjU4Y2NlNTljOWUzZDI4NzExMWEzYjEzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ATvZ9m3NrqE2UvzKFeZ6sCPs7qT3RbASKi2jwmoMJQw)
Everything works as expected. Thank you for the great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At 375PX,
some delete buttons are going out of the viewport, please fix the alignment of the buttons.
pr2446.mp4
e2bd836
…ighestGoodNetworkApp into Nahiyan_Optimize-Permissions-Management-Page
@KaushikMreddy The header is not solely part of the permission management page. It is its component and there is a PR handling this. |
…ighestGoodNetworkApp into Nahiyan_Optimize-Permissions-Management-Page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I logged in as the local Admin User and tested Pull Request #2446. Everything works as expected in both dark mode and light mode, with a viewport of 375px wide and above.
please find the video for reference.
mobile.display.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ighestGoodNetworkApp into Nahiyan_Optimize-Permissions-Management-Page
Description
Optimized permissions management page for all viewports 375px wide and above.
Related PRS (if any):
This frontend PR is related to the dev backend
Main changes explained:
How to test:
npm install
andnpm run start:local
to run this PR locallyScreenshots or videos of changes: