-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Koushica - Schedule Blue Square Reason - Start Week Confirmation Modal #3022
base: development
Are you sure you want to change the base?
Koushica - Schedule Blue Square Reason - Start Week Confirmation Modal #3022
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The modal is supposed to be popped up for next and future weeks off, as specified in the requirements, but modal is just popped up for next week sunday off,
pr3022_Cp.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The modal is supposed to be popped up for next and future weeks off, as specified in the requirements, but modal is just popped up for next week sunday off,
- And in case modal being popped up, it should be dismissed from the screen after choosing the 2 options provided, but it is still on the screen.
pr3022_Cp.mov
Hello @srikanthpusthem,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the PR in both light and dark mode and everything works as expected.
The new modal to confirm the week start was triggered only for the immediate next week's Sunday. For the rest other week not before the current week, it was working as before. Thank you for your work.
Description
Related PRS (if any):
No related PRs.
Main changes explained:
How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
Before:
before.mov
After:
after.mov
Note:
Try different Sundays:
Please verify in both Light and dark modes