Nanguan Add test for CreateNewBadgePopup.jsx #3027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Nahiyan-16
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Hi Nanguan,
Great job on the PR! The tests for CreateNewBadgePopup are well-structured and cover key functionality like rendering, conditional fields, form validation, and data submission. I appreciate how you used jest.mock for action handling and fireEvent for simulating user interactions. One suggestion would be to explore edge cases like unexpected inputs or API failures to make the coverage even more robust. Overall, this is a solid contribution—nice work!
ManasaViswanadhapalli
approved these changes
Jan 11, 2025
srikanthpusthem
approved these changes
Jan 11, 2025
|
Works perfect |
Maddila-Anjali
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace #2894
Test following as requested by #2894 (review)
Render Verification:
Add assertions for all key elements (e.g., input fields, dropdowns, buttons) to ensure they render correctly. Verifying just the "create" button alone isn't adequate
Conditional Logic:
Test visibility of fields that appear or change based on the selected badge type (e.g., showTotalHrs, showWeeks).
Button State:
Verify the "Create" button is enabled or disabled based on input validity.
Form Submission:
Mock the createNewBadge function and verify it is called with the correct data on form submission.
result
cc @KurtisIvey