Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samarth B - lint fix reducer #3030

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Samarth B - lint fix reducer #3030

wants to merge 2 commits into from

Conversation

samarth9201
Copy link
Contributor

@samarth9201 samarth9201 commented Jan 11, 2025 •
edited
Loading

Description

Fixed Linting errors in src/components/TeamMemberTasks/**

Related PRS (if any):

This frontend PR is not related to backend PR.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as any user
  5. The App should work as normal
  6. Run npm run test to make sure all tests are passing.
  7. Run npm run lint tp check linting

@netlify Netlify
Copy link

netlify bot commented Jan 11, 2025 •
edited
Loading

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit dd3c579
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67829dc251aaf00008895a5f
😎 Deploy Preview https://deploy-preview-3030--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

srikanthpusthem
srikanthpusthem approved these changes Jan 19, 2025
View reviewed changes
Copy link

@srikanthpusthem srikanthpusthem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image linting issues fixed, no linting issues showed

ziddigsm
ziddigsm approved these changes Jan 25, 2025
View reviewed changes
Copy link

@ziddigsm ziddigsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases pass successfully. No Lint issues detected.
Screenshot 2025-01-24 at 11 00 35 PM
Screenshot 2025-01-24 at 11 01 19 PM

vishavk1992
vishavk1992 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@vishavk1992 vishavk1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR and everything working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziddigsm ziddigsm ziddigsm approved these changes

@vishavk1992 vishavk1992 vishavk1992 approved these changes

@srikanthpusthem srikanthpusthem srikanthpusthem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samarth9201 @srikanthpusthem @vishavk1992 @ziddigsm