Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug10:Quick Setup Tool: Eliminate need for additional saving of changes #3031

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Watchdog00
Copy link

@Watchdog00 Watchdog00 commented Jan 12, 2025

Description

Bug10 Fixes #10 (bug list priority high)

Related PRS (if any):

No related PRs.

Main changes explained:

(1) The "Save Changes" button was removed below the "Add New QST" button.

(2) In the "Click Existing" functionality, deleting QSC are now saved automatically.

(3) In the "Add A New Title" functionality, after clicking "Confirm," the changes are saved automatically.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ View Profiles
  6. Confirm that the "Save Changes" button has been removed and is no longer visible below the "Add New QST" button.
  7. Test Adding a New QST: Click the "Add New QST" button -> Fill out the form with valid information -> Click "Confirm." -> Verify that the new QST is successfully added to the list.
  8. Test Deleting a QST: Click on the newly added QST -> Press the "Delete QSC" button -> Confirm that the selected QST is successfully removed from the list.

Screenshots or videos of changes:

Before Removal of "Save Change" Button
Before Removal of Save Change Button
After Removal of "Save Change" Button
After Removal of Save Change Button

Bug10.Testing.mov

Note:

Copy link

netlify bot commented Jan 12, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit f15ea9e
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/6783605bd7b3c80008d35dc1
😎 Deploy Preview https://deploy-preview-3031--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wander2ec
Copy link

everything is ok
3031

@Maddila-Anjali
Copy link

Adding and removing the QSC works perfectly alright.
After adding, it looks as follows: ( I added lang here)
PR-3031(a)

After deleting, it looks as follows:
PR-3031(b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants