Swathi - Add Project Name to Projects>Members Pages #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lemonnycodes
added
the
High Priority - Please Review First
Lemonnycodes
added
High Priority - Please Review First
|
everything is ok. |
Ankuriboh
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Test file was overridden by actual business logic.
Eveye2023
approved these changes
Jan 17, 2025
| @@ -102,9 +103,11 @@ const Members = props => { | |||
| </button> | |||
| </NavItem> | |||
|
|
|||
| <div id="member_project__name">PROJECTS {props.projectId}</div> | |||
| {/* Display Project Name */} | |||
| <div id="member_project__name">PROJECT: {projectName}</div> | |||
There was a problem hiding this comment.
I was wondering, both the member's page and the WBS page have a project header. Do you think it might be helpful to make it a shared component, or is there a specific reason for keeping them separate?
|
The Members page correctly displays the selected project name. See the attached screenshot. The same results are observed for both Admin and Owner users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes functionality and display issues on the Members page and ensures that the project name is correctly displayed at the top of the page.
Related PRS (if any):
This frontend PR is related to the development branch of the backend
Main changes explained:
How to test:
Screenshots or videos of changes:
video.mp4