Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrinalini - Fixed Leaderboard refresh does not refresh timeoff issue #3041

Open
wants to merge 15 commits into
base: development
Choose a base branch
from

Conversation

mrinalini-raghavendran19

Description

Screenshot 2025-01-16 at 4 29 56 PM

Fixes # (bug list priority high)
(PRIORITY HIGH) Jae

Related PRS (if any):

N/A

Main changes explained:

  1. Made change in the Leaderboard.jsx file in src/components/LeaderBoard/Leaderboard.jsx in updateLeaderboardHandler function.
  2. Added a dispatch() to the thunk function in timeOffRequestAction.js which essentially updates changes made to the time off requests in leaderboard in real time.

How to test:

  1. Check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin/ owner user
  5. Open another tab (logged in with the same credentials)
  6. On one tab navigate to View Profile -> Make a time off request/ delete a time off request
  7. On the other tab navigate to Dashboard -> Leaderboard -> Hit the Refresh icon -> search for user that you requested time off for -> Notice any changes to the time off icon (either disappearing if deleted or updated with new time off request)
  8. verify this new feature works in dark mode

Screenshots or videos of changes:

Screen.Recording.2025-01-16.at.4.42.05.PM.mov

@mrinalini-raghavendran19 mrinalini-raghavendran19 changed the title Leaderboard refresh issue Fixed Leaderboard refresh does not refresh timeoff issue Jan 17, 2025
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 2719541
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/6789f2e08f190500085f9c0e
😎 Deploy Preview https://deploy-preview-3041--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mrinalini-raghavendran19 mrinalini-raghavendran19 deleted the leaderboard-refresh-issue branch January 17, 2025 00:54
@mrinalini-raghavendran19 mrinalini-raghavendran19 restored the leaderboard-refresh-issue branch January 17, 2025 01:01
@mrinalini-raghavendran19 mrinalini-raghavendran19 changed the title Fixed Leaderboard refresh does not refresh timeoff issue Mrinalini - Fixed Leaderboard refresh does not refresh timeoff issue Jan 17, 2025
@Maddila-Anjali
Copy link

Works fine. Was able to add and delete the blue square as well. Checked it on dark mode as well, and this is the output.
PR-3041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants