-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ramakrishna added report icon and completed tasknumbers in taskmemebers dashboard #3042
base: development
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this PR and verify that under Team Member name I was able to see a Report icon and task numbers. Clicking on both of these buttons, I was able to navigate to that individual people report icon.
Icons under team member name under tasks
Clicking on it navigated to the individual person report page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
task => | ||
task.resources?.some( | ||
resource => resource.userID === user.personId && resource.completedTask, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why is some
used here? Does it mean we don't need to ensure that all the resources in a single task are completed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the following error while testing(see video), the people number is 0.
I tried clearing the cache, rebuilding the front and backend, switching to another owner account, switching to another admin account. But doesn't seem to fix the issue
PR3042.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Or Implements # (WBS)
Related PRS (if any):
Please use latest development backend branch to test PR
…
Main changes explained:
…
How to test:
npm install
and...
to run this PR locally