Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramakrishna added report icon and completed tasknumbers in taskmemebers dashboard #3042

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Ramaruva
Copy link
Contributor

Description

image

Or Implements # (WBS)

Related PRS (if any):

Please use latest development backend branch to test PR

Main changes explained:

  • Added an new repotsicon png file in public folder.
  • Added two new links and task completed numbers calculation in teammembertask.jsx
  • Added respective style for links in style.css

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin/owner user or any user who has permission to see people reports page.
  5. go to dashboard→ Tasks
  6. verify that for under Team Member name that you are able to see a Report icon and task numbers( it is related no of task completed).
  7. verify that while clicking on both of these elements you are able to navigate to that individual people report icon.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit ed8b1c1
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/678a932ca0ef360008db9323
😎 Deploy Preview https://deploy-preview-3042--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@srikanthpusthem srikanthpusthem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image both the buttons are working as expected

Copy link
Contributor

@nikhilgiri0226 nikhilgiri0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and verify that under Team Member name I was able to see a Report icon and task numbers. Clicking on both of these buttons, I was able to navigate to that individual people report icon.

Icons under team member name under tasks
image

Clicking on it navigated to the individual person report page
image

@SaumitC SaumitC added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jan 20, 2025
@Ramaruva Ramaruva changed the title added report icon and completed tasknumbers in taskmemebers dashboard Ramakrishna added report icon and completed tasknumbers in taskmemebers dashboard Jan 20, 2025
Copy link

@Eveye2023 Eveye2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions work as expected.
Screenshot 2025-01-21 at 2 22 15 PM

task =>
task.resources?.some(
resource => resource.userID === user.personId && resource.completedTask,
),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is some used here? Does it mean we don't need to ensure that all the resources in a single task are completed?

Copy link

@jeyanthi-sm jeyanthi-sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR and confirmed that the Report icon and the number of tasks completed are visible on the dashboard under "Task." Additionally, clicking on them successfully navigates to the People Report section. Screenshots are attached.
PR_3042
PR_3042_Report_Team_member

Copy link
Contributor

@honglinchen0524 honglinchen0524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the following error while testing(see video), the people number is 0.
I tried clearing the cache, rebuilding the front and backend, switching to another owner account, switching to another admin account. But doesn't seem to fix the issue

PR3042.mp4

Copy link

@sharansaim sharansaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are working as expected, successfully verified.
Report PR
Report PR1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants