Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Check subscription Id before executing delete and update subscription operations #2223

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Nov 26, 2024

Description

One Line Summary

Changed canStartExecute in UpdateSubscriptionOperation and DeleteSubscriptionOperation to match TransferSubscriptionOperation

Details

Motivation

Removes redundant logic - likely a typo from copy and pasting

Testing

Unit testing

In Android Studio, ran tests in 'com.onesignal' and passed

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Change canStartExecute in UpdateSubscriptionOperation and DeleteSubscriptionOperation to match TransferSubscriptionOperation
Copy link
Contributor

@jinliu9508 jinliu9508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@shepherd-l shepherd-l merged commit 7c15a59 into main Nov 27, 2024
2 checks passed
@shepherd-l shepherd-l deleted the fix/canStartExecute branch November 27, 2024 18:21
@jinliu9508 jinliu9508 mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants