Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove email and remove sms #805

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Dec 18, 2023

Description

One Line Summary

Fixes removeEmail calls on Android and iOS and removeSms calls on iOS

Details

Motivation

Fixes errors when calling removeEmail on Android and iOS and removeSms on iOS

Scope

No changes to the public API as fixes apply to native calls to OneSignal Android and iOS SDKs

Call arguments for removeEmail and removeSms do not have defined keys in user.dart and calling with a key returns an error on iOS.
Fix could be done one of 2 ways:

  1. Remove the key value in OSFlutterUser.m
    • What was done in this PR
  2. Add the key value defined in OSFlutterUser.m (@"email", @"smsNumber") to user.dart
    • This also requires the key value to be added to Android in OneSignalUser.java

Testing

Manual testing

Tested removeEmail and removeSms on an user with emails and sms subscriptions and with none, app build of the OneSignal example app on on a emulated Pixel 4 with Android 12 and physical iPhone 12 with iOS 15.5.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Pass email arguement down to native SDK method
Call arguments for remove email and remove sms do not have defined keys in user.dart and calling with a key returns an error on iOS
@shepherd-l shepherd-l merged commit eb6ea37 into user_model/main Dec 18, 2023
2 checks passed
@shepherd-l shepherd-l deleted the fix/removeEmail branch December 18, 2023 19:57
nan-li pushed a commit that referenced this pull request Jan 31, 2024
[Fix] Remove email and remove sms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants