Skip to content

Commit

Permalink
Moved OneSignal.context access down a level
Browse files Browse the repository at this point in the history
* Clean up - Moved access to OneSignal.context.serviceWorkerManager
down one call
stack from getRawPushSubscriptionFromServiceWorkerRegistration
to getRawPushSubscription
  • Loading branch information
jkasten2 committed Feb 19, 2021
1 parent b3de742 commit 0b6b420
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/helpers/SubscriptionHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,7 @@ export default class SubscriptionHelper {
return subscription;
}

static async getRawPushSubscriptionFromServiceWorkerRegistration(): Promise<RawPushSubscription | null> {
const registration = await OneSignal.context.serviceWorkerManager.getRegistration();
static async getRawPushSubscriptionFromServiceWorkerRegistration(registration?: ServiceWorkerRegistration): Promise<RawPushSubscription | null> {
if (!registration) {
return null;
}
Expand Down Expand Up @@ -190,7 +189,8 @@ export default class SubscriptionHelper {
}

if (environmentInfo.isBrowserAndSupportsServiceWorkers) {
return await SubscriptionHelper.getRawPushSubscriptionFromServiceWorkerRegistration();
const registration = await OneSignal.context.serviceWorkerManager.getRegistration();
return await SubscriptionHelper.getRawPushSubscriptionFromServiceWorkerRegistration(registration);
}

return null;
Expand Down

0 comments on commit 0b6b420

Please sign in to comment.