Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade uikit to 3.21.13 #893

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

jaredkhan
Copy link
Collaborator

Addresses #877

@jaredkhan
Copy link
Collaborator Author

Should probably have a poke and make sure this didn't affect anything else.

@jaredkhan jaredkhan marked this pull request as ready for review November 13, 2024 23:28
@jaredkhan
Copy link
Collaborator Author

jaredkhan commented Nov 13, 2024

Well I've been using this locally for a while now and not noticed any new uikit-related issues.
Dropdowns and sliders seem to be working fine on desktop and mobile.
And fixing the double-tap-to-type problem makes me very happy.

@lentinj lentinj merged commit 062a78a into OneZoom:main Nov 14, 2024
1 check passed
@lentinj
Copy link
Collaborator

lentinj commented Nov 14, 2024

Sounds good to me. The most problematic case in the past is the search dropdown, as it's quite customised vs. the UI-kit defaults, but given that's what started this I'm guessing you've poked around with it pretty thoroughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants