More events #11
Merged
More events #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrockWS
reviewed
Jan 15, 2019
BrockWS
reviewed
Jan 15, 2019
UpcraftLP
requested changes
Jan 15, 2019
UpcraftLP
reviewed
Jan 15, 2019
UpcraftLP
reviewed
Jan 15, 2019
UpcraftLP
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, not sure how we should actually go about this.
ToolTipDrawEvent should be fine however
GuiDrawEvent is where we run into an issue of, the event itself is fine, however in #10 it suggests InGameHud && DebugHud as events with their respective draw methods, do we make those as separate events, or do we make it all part of GuiDrawEvent and make an DrawEventTypes and return a respective type based on where it's called?