Rework scope cleanup microservice #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
=======================================
Coverage 79.40% 79.40%
=======================================
Files 523 523
Lines 40905 40910 +5
=======================================
+ Hits 32480 32486 +6
+ Misses 8425 8424 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
ryanmelt
requested changes
Feb 12, 2025
| areas = [ | ||
| ["#{@scope}/text_logs", scope.text_log_retain_time], | ||
| ["#{@scope}/tool_logs", scope.tool_log_retain_time], | ||
| ["#{@scope}/text_logs/openc3_log_messages", scope.text_log_retain_time], |
There was a problem hiding this comment.
Why did these paths get more specific? That wont support future changes.
There was a problem hiding this comment.
We will improve this in the future if needed.
ryanmelt
approved these changes
Feb 12, 2025
This was referenced Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.