Astro #943

jmthomas · 2023-11-20T04:51:05Z

No description provided.

codecov · 2023-11-21T01:08:47Z

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (6bf1244) 75.68% compared to head (59a6abc) 75.62%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
...ool-tlmgrapher/src/tools/TlmGrapher/TlmGrapher.vue	38.46%	8 Missing ⚠️
...smonitor/src/tools/LimitsMonitor/LimitsControl.vue	66.66%	3 Missing and 1 partial ⚠️
...cketviewer/src/tools/PacketViewer/PacketViewer.vue	50.00%	3 Missing ⚠️
...-tlmviewer/src/tools/TlmViewer/NewScreenDialog.vue	33.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
- Coverage   75.68%   75.62%   -0.06%     
==========================================
  Files         620      620              
  Lines       43900    43946      +46     
  Branches      890      902      +12     
==========================================
+ Hits        33224    33234      +10     
- Misses      10576    10613      +37     
+ Partials      100       99       -1

Flag	Coverage Δ
frontend	`60.39% <72.13%> (-0.17%)`	⬇️
python	`84.08% <ø> (-0.06%)`	⬇️
ruby-api	`48.62% <ø> (ø)`
ruby-backend	`80.53% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ryanmelt

That's a lot of updates!

jmthomas · 2023-11-22T01:08:51Z

That's a lot of updates!

I'd like to go over this in detail when you get back

jmthomas · 2023-12-09T16:31:42Z

openc3-cosmos-init/Dockerfile

+# Build docs tool
+COPY --from=docs . packages/openc3-cosmos-tool-docs/
+RUN cd packages/openc3-cosmos-tool-docs/scripts && ruby generate_docs_from_yaml.rb PLUGIN && yarn
+RUN ["/openc3/plugins/docker-package-build.sh", "openc3-cosmos-tool-docs"]


Docs seems to take the longest so I moved things around

jmthomas · 2023-12-09T16:32:41Z

openc3-cosmos-init/plugins/packages/openc3-cosmos-demo/targets/INST/screens/adcs.txt

@@ -7,27 +7,29 @@ VERTICAL
  HORIZONTAL
    VERTICALBOX "Position and Velocity"
      LABELVALUE <%= target_name %> ADCS POSX WITH_UNITS 20 CENTER
+        # We recommend using these built-in colors from 1-8
+        SETTING TEXTCOLOR var(--color-data-visualization-1)


Example of using the Astro visualization colors ... this is what we recommend but they can still use color names or RGB hex values.

jmthomas · 2023-12-09T16:35:48Z

...-cosmos-init/plugins/packages/openc3-cosmos-tool-autonomic/src/tools/Autonomic/Autonomic.vue

@@ -48,7 +48,7 @@ export default {
  },
  data() {
    return {
-      title: 'COSMOS Autonomic',
+      title: 'Autonomic',


Removed 'COSMOS' from all tool titles to shorten them up

jmthomas · 2023-12-09T16:36:35Z

openc3-cosmos-init/plugins/packages/openc3-cosmos-tool-autonomic/src/tools/Autonomic/Events.vue

        single-line
        hide-details
+        style="max-width: 350px"


All search boxes now prepend-inner-icon for search, are clearable, outlined, dense, and have a max-width

jmthomas · 2023-12-09T16:41:48Z

...t/plugins/packages/openc3-cosmos-tool-limitsmonitor/src/tools/LimitsMonitor/LimitsEvents.vue

@@ -73,6 +80,7 @@ export default {
      search: '',
      headers: [
        { text: 'Time', value: 'time_nsec', width: 250 },
+        { text: 'Level', value: 'level', sortable: false },


Added level with Astro icon to the limits events table

jmthomas · 2023-12-09T17:09:46Z

...os-init/plugins/packages/openc3-tool-common/src/tools/admin/ClassificationBannerSettings.vue

+      } else {
+        this.bottomHeight = 0
+      }
+    },


Height can still be changed but this fixes the issue where you forget to set the height and it's just 0 and doesn't appear. Basically I'm setting a sensible default.

jmthomas · 2023-12-09T17:11:55Z

...-cosmos-init/plugins/packages/openc3-tool-common/src/tools/base/components/Notifications.vue

+          label="Notifications"
+          :status="iconStatus"
+          :notifications="unreadNotifications.length"
+        ></rux-monitoring-icon>


Use Astro monitoring-icon for the app bar

jmthomas · 2023-12-09T17:13:06Z

...-cosmos-init/plugins/packages/openc3-tool-common/src/tools/base/components/Notifications.vue

@@ -273,6 +269,8 @@ export default {
  created: function () {
    this.showToast = localStorage.notoast === 'false'
    this.subscribe()
+    // TODO How does this get updated after initialization
+    this.alerts = this.$store.state.notifyHistory


Alerts / notifications still needs some work. I think all the information is here. I left the current implementation where the bell icon always shows and everything is basically a notification.

jmthomas · 2023-12-09T17:14:18Z

openc3-cosmos-init/plugins/packages/openc3-tool-common/src/tools/base/components/UserMenu.vue

+        ]
+          .map((element) => self.capitalize(element))
+          .sort()
+          .join(', ')


I'm just showing all the roles. Astro icon will just truncate the list if it gets too large but our default roles work really well like "Admin, Viewer" or "Operator, Viewer".

jmthomas · 2023-12-09T17:15:36Z

openc3/data/config/target_config.yaml

-    Ruby files must be required to be available to call in other code.
-    Files are first required from the target's lib folder. If no file is found the
-    Ruby system path is checked which includes the base openc3/lib folder.
+  description: Ruby files optionally be required to explicitly declare dependencies.


It's optional. I'd be ok removing it but I guess it's interesting to explicitly declare dependencies.

ryanmelt

Just need to fix cfs doc

ryanmelt · 2023-12-09T22:46:59Z

docs.openc3.com/docs/guides/cfs.md

@@ -96,7 +96,7 @@ Note we're connecting to the COSMOS network (`docker network ls`) and exposing t

 ```bash
 docker build -t cfs .
-docker run --cap-add CAP_SYS_RESOURCE --net=openc3-cosmos-network --name cfs -p1234:1234 -p1235:1235 cfs
+docker run --cap-add CAP_SYS_RESOURCE --net=openc3-cosmos-network --name cfs -p1234:1234/udp -p1235:1235/udp cfs


Other commenter said not to add /udp to 1235

Don't forget to fix this.

sonarqubecloud · 2023-12-10T18:31:34Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

No Coverage information
3.9% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

jmthomas added 3 commits November 19, 2023 19:46

Astro css

67d32af

Astro css

74659c4

Astro settings

3ff6fa1

jmthomas requested a review from ryanmelt November 20, 2023 04:51

Further Astro compliance

0a31c4e

jmthomas added 2 commits November 21, 2023 08:38

Fix playwright

4e6cb98

Fix playwright

dc99d78

ryanmelt approved these changes Nov 21, 2023

View reviewed changes

jmthomas added 13 commits November 24, 2023 12:01

Cleanup around target-packet-item-chooser

738b015

Fix navbar and dropdown text color

165e622

Limits set selection in menu

5f96289

Cleanup screens and add astro colors

f74234e

Many astro updates

40b44e9

Merge branch 'main' into astro

7773937

Minor updates

92561a9

Fix yaml and graph spacing

2ecddbf

Create Astro topbar

f834919

Remove AlertHistory

736a866

Fix playwright

d5877bc

Fix layouts and playwright

410a5d5

Add GraphWidget items to screen. Fix calendar colors

d641261

jmthomas commented Dec 9, 2023

View reviewed changes

jmthomas added 2 commits December 9, 2023 10:17

Minor cleanup

e7adc10

Minor hs.txt fix

cb7728f

ryanmelt approved these changes Dec 9, 2023

View reviewed changes

Fix playwright

59a6abc

jmthomas merged commit bd8c0b2 into main Dec 10, 2023
23 of 25 checks passed

jmthomas deleted the astro branch December 10, 2023 19:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Astro #943

Astro #943

jmthomas commented Nov 20, 2023

codecov bot commented Nov 21, 2023 •

edited

Loading

ryanmelt left a comment

jmthomas commented Nov 22, 2023

jmthomas Dec 9, 2023

jmthomas Dec 9, 2023

jmthomas Dec 9, 2023

jmthomas Dec 9, 2023

jmthomas Dec 9, 2023

jmthomas Dec 9, 2023

jmthomas Dec 9, 2023

jmthomas Dec 9, 2023

jmthomas Dec 9, 2023

jmthomas Dec 9, 2023

ryanmelt left a comment

ryanmelt Dec 9, 2023

ryanmelt Dec 10, 2023

sonarqubecloud bot commented Dec 10, 2023

Astro #943

Astro #943

Conversation

jmthomas commented Nov 20, 2023

codecov bot commented Nov 21, 2023 • edited Loading

Codecov Report

ryanmelt left a comment

Choose a reason for hiding this comment

jmthomas commented Nov 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanmelt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 10, 2023

codecov bot commented Nov 21, 2023 •

edited

Loading