Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Key Concepts page #950

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Add Key Concepts page #950

merged 4 commits into from
Dec 11, 2023

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Nov 24, 2023

I'll need to regenerate the site before merge but check this out and let me know what you think. This is the result of a few recent discussions we've had about confusion about the architecture and things we're doing.

closes #816

@jmthomas jmthomas requested a review from ryanmelt November 24, 2023 16:19
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aaa454d) 75.70% compared to head (c3c9c21) 75.73%.
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
+ Coverage   75.70%   75.73%   +0.02%     
==========================================
  Files         620      620              
  Lines       43741    43744       +3     
  Branches      878      878              
==========================================
+ Hits        33114    33129      +15     
+ Misses      10532    10521      -11     
+ Partials       95       94       -1     
Flag Coverage Δ
python 84.07% <ø> (+0.09%) ⬆️
ruby-api 48.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas
Copy link
Member Author

jmthomas commented Dec 7, 2023

closes #961

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good new content!
I don't really like differentiating images and containers. I think that just confuses users. I would just describe each of the containers, and not differentiate.


## Projects

The main COSMOS [repo](https://github.com/OpenC3/cosmos) contains all the source code used to build and run COSMOS. However, users (not developers) of COSMOS should use the COSMOS [project](https://github.com/OpenC3/cosmos-project) to launch COSMOS. The project consists of the [openc3.sh](https://github.com/OpenC3/cosmos-project/blob/main/openc3.sh) and [openc3.bat](https://github.com/OpenC3/cosmos-project/blob/main/openc3.bat) files for starting and stopping COSMOS, the [compose.yaml](https://github.com/OpenC3/cosmos-project/blob/main/compose.yaml) for configuring the COSMOS containers, and the [.env](https://github.com/OpenC3/cosmos-project/blob/main/.env) file for setting runtime variables.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally it contains user modifiable config files for both Redis and Traefik.

| [openc3-base](https://github.com/OpenC3/cosmos/blob/main/openc3/Dockerfile) | Builds on openc3-ruby and includes all the COSMOS source code |
| [openc3-node](https://github.com/OpenC3/cosmos/blob/main/openc3-node/Dockerfile) | Builds on openc3-base and includes NodeJS for COSMOS frontend development |
| [openc3-cosmos-init](https://github.com/OpenC3/cosmos/blob/main/openc3-cosmos-init/Dockerfile) | Builds on openc3-node, copies all the COSMOS tools and builds them |
| [openc3-operator](https://github.com/OpenC3/cosmos/blob/main/openc3-operator/Dockerfile) | Sets up the base image to run microservice_operator.rb |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent - does not mention builds on openc3-base

| cosmos-enterprise-openc3-metrics-1 | Rails server that provides metrics on COSMOS performance |
| cosmos-enterprise-openc3-keycloak-1 | Single-Sign On service for authentication |
| cosmos-enterprise-openc3-postgresql-1 | SQL Database for use by Keycloak |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also includes nfs in Kubernetes.

| cosmos-openc3-minio-1 | Provides a S3 like bucket storage interface and also serves as a static webserver for the tool files |
| cosmos-openc3-traefik-1 | Provides a reverse proxy and load balancer with routes to the COSMOS endpoints |

The image list for [Enterprise COSMOS](https://openc3.com/enterprise) consists of the following:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

containers.

@jmthomas jmthomas merged commit d34bedc into main Dec 11, 2023
13 of 14 checks passed
@jmthomas jmthomas deleted the key_concepts branch December 11, 2023 21:53
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to configure COSMOS to talk to external hardware
2 participants