Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tlm apis #970

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Cleanup tlm apis #970

merged 3 commits into from
Dec 12, 2023

Conversation

jmthomas
Copy link
Member

telemetry is now tlm, tlm apis take a single string arg

@jmthomas jmthomas requested a review from ryanmelt December 11, 2023 23:33
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (1741f51) 75.67% compared to head (e9b0424) 75.67%.

Files Patch % Lines
openc3/python/openc3/api/tlm_api.py 90.00% 5 Missing ⚠️
openc3/lib/openc3/api/tlm_api.rb 92.68% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
- Coverage   75.67%   75.67%   -0.01%     
==========================================
  Files         620      620              
  Lines       44039    44088      +49     
  Branches      902      902              
==========================================
+ Hits        33328    33362      +34     
- Misses      10611    10625      +14     
- Partials      100      101       +1     
Flag Coverage Δ
frontend 60.60% <100.00%> (-0.04%) ⬇️
python 84.03% <90.00%> (-0.05%) ⬇️
ruby-api 48.62% <ø> (ø)
ruby-backend 80.54% <92.68%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas merged commit d3955b0 into main Dec 12, 2023
23 checks passed
@jmthomas jmthomas deleted the tlm_api branch December 12, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants