Add checks to plugin undeploy

[ryanmelt]

No description provided.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (33fffc3) 75.42% compared to head (deb694d) 75.40%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
openc3/lib/openc3/models/plugin_model.rb	45.00%	11 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
- Coverage   75.42%   75.40%   -0.03%     
==========================================
  Files         589      589              
  Lines       42784    42800      +16     
  Branches      746      746              
==========================================
+ Hits        32271    32272       +1     
- Misses      10435    10450      +15     
  Partials       78       78              

Flag	Coverage Δ
python	84.03% <ø> (-0.05%)	⬇️
ruby-api	48.62% <ø> (ø)
ruby-backend	80.51% <45.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmthomas]

Is this just a best effort with capturing possible errors? So on an upgrade if you get an error on uninstall the new install will not proceed.

[ryanmelt]

I was thinking the error before we had was with people constantly upgrading the same plugin and sometimes having errors during the upgrade. A partial undeploy would leave a target behind. I wanted to better detect that situation, and make sure to cleanup as much as possible.