Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Tools entity version are not fillable (#9330) #9525

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • Add tool_version field

Related issues

@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Jan 8, 2025
@SarahBocognano SarahBocognano self-assigned this Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.18%. Comparing base (bc9fc0f) to head (ff33912).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9525   +/-   ##
=======================================
  Coverage   65.17%   65.18%           
=======================================
  Files         630      630           
  Lines       60188    60188           
  Branches     6728     6729    +1     
=======================================
+ Hits        39230    39235    +5     
+ Misses      20958    20953    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richard-julien richard-julien force-pushed the master branch 4 times, most recently from f3d2300 to e2ea841 Compare January 12, 2025 14:50
@Gwendoline-FAVRE-FELIX
Copy link
Member

It works for adding the field at creation and for modifying it.
But when modifying, the field is not pre-filled with the existing value.
Tool update

@Gwendoline-FAVRE-FELIX
Copy link
Member

I don't know if versions can be that long, but if they are, the value is not truncated and is on top of the adjacent field.
Tool truncate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants