-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use for-loop instead of slower any() with generator expression #66
Conversation
https://github.com/OpenDataServices/cove/pull/609/files#diff-e4978c21ecf1ac03267a96314f0f0e88 added an early return in |
This is causing the lib-cove-oc4ids tests to fail, and I've not had chance to dig into what's going on, so leaving this unmerged for now. |
Re-measuring using the commands in open-contracting/lib-cove-oc4ids#23, the time spent in the type validator drops from 10% to 6%. Before: After: |
Drops time spent in type validator from 13% to 7%
Before:
After: