Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #853 - repair classloader for spring #870

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

kamilkrzywanski
Copy link
Contributor

No description provided.

@kamilkrzywanski
Copy link
Contributor Author

@velo
Build fails but fixed with #872

@velo velo enabled auto-merge (squash) February 7, 2025 11:24
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for fixing it!

I saw your issue contains a lot of valuable information
#853

Are you able to also include a unit test or an example project HERE so this never happens again?

Cheers

@kamilkrzywanski
Copy link
Contributor Author

@velo Will include some tests later :)

auto-merge was automatically disabled February 7, 2025 20:23

Head branch was pushed to by a user without write access

@kamilkrzywanski
Copy link
Contributor Author

@velo test attached

@velo
Copy link
Member

velo commented Feb 12, 2025

Ok, please run maven locally with '-Pdev' to make sure all files are properly formatted

@kamilkrzywanski
Copy link
Contributor Author

Right, [ERROR] Failed to execute goal com.cosium.code:git-code-format-maven-plugin:5.3:validate-code-format (validate-code-format) on project querydsl-codegen-utils: /root/querydsl/querydsl-tooling/querydsl-codegen-utils/src/test/java/com/querydsl/codegen/utils/support/ClassLoaderWrapper.java is not correctly formatted ! -> [Help 1]
Will fix it later :)

@kamilkrzywanski
Copy link
Contributor Author

@velo fixed

@velo velo merged commit 294d7e0 into OpenFeign:master Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants