Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle parameterized mapped superclass issue #891 #892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpmsilva
Copy link

Refer to issue #891 for the complete report.

This PR handles the issue by adding out keywords to the generated Q-classes when they are needed.

@jpmsilva
Copy link
Author

There appears to be a build error regarding a change in the signature of one of the utility methods of Extensions.kt.

I would defer to the maintainers on how to best approach that change. If need be I can probably work around the issue by duplicating code and maintain the existing signatures. However, could it be that these are internal undocumented methods, and perhaps therefore not subject to strict semver obligations?

@velo
Copy link
Member

velo commented Feb 13, 2025

I would defer to the maintainers on how to best approach that change. If need be I can probably work around the issue by duplicating code and maintain the existing signatures. However, could it be that these are internal undocumented methods, and perhaps therefore not subject to strict semver obligations?

Yeah, I would say for now duplicate code, deprecate old methods and keep signatures intact.

  • com.querydsl.kotlin.codegen.ExtensionsKt.asTypeName(com.querydsl.codegen.utils.model.Type):METHOD_REMOVED
  • com.querydsl.kotlin.codegen.ExtensionsKt.parameterizedBy(kotlin.reflect.KClass,com.squareup.kotlinpoet.TypeName[]):METHOD_RETURN_TYPE_CHANGED

@velo velo requested a review from IceBlizz6 February 13, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants