Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

986 input validation for directory names #1024

Merged
merged 14 commits into from
Dec 7, 2024
Merged

986 input validation for directory names #1024

merged 14 commits into from
Dec 7, 2024

Conversation

atravitz
Copy link
Contributor

@atravitz atravitz commented Nov 21, 2024 •
edited
Loading

addresses #986

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz linked an issue Nov 21, 2024 that may be closed by this pull request
input validation for directory/json names #986
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (cb25ce5) to head (6d46678).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1024   +/-   ##
=======================================
  Coverage   92.83%   92.84%           
=======================================
  Files         134      134           
  Lines        9961     9973   +12     
=======================================
+ Hits         9247     9259   +12     
  Misses        714      714
Flag Coverage Δ
fast-tests 92.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atravitz atravitz requested a review from IAlibay November 21, 2024 22:54
@atravitz atravitz marked this pull request as ready for review November 21, 2024 22:54
IAlibay
IAlibay requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just a bit more documentation would be great though!

news/986_input_validation.rst Outdated Show resolved Hide resolved
openfecli/commands/quickrun.py Outdated Show resolved Hide resolved
@atravitz atravitz requested a review from IAlibay December 5, 2024 00:17
IAlibay
IAlibay approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

🚨 API breaking changes detected! 🚨

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

🚨 API breaking changes detected! 🚨

@atravitz atravitz enabled auto-merge December 6, 2024 23:56
@atravitz atravitz disabled auto-merge December 7, 2024 00:40
@atravitz atravitz merged commit c2e4ee9 into main Dec 7, 2024
12 of 13 checks passed
@atravitz atravitz deleted the 986-input-validation-for-directory-names branch December 7, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAlibay IAlibay IAlibay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

input validation for directory/json names
2 participants
@atravitz @IAlibay