switch ci matrix to test against gufe main again #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 API breaking changes detected! 🚨 |
atravitz
force-pushed
the
test_against_gufe_main
branch
from
48aa1d6 to
01f5803
Compare
|
🚨 API breaking changes detected! 🚨 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1050 +/- ##
==========================================
- Coverage 94.50% 92.79% -1.71%
==========================================
Files 134 134
Lines 9986 9986
==========================================
- Hits 9437 9267 -170
- Misses 549 719 +170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
on second thought, I'm not sure there's reason for us to keep the CI failing with a test against |
IAlibay
approved these changes
Dec 12, 2024
IAlibay
reviewed
Dec 12, 2024
|
I think we should be testing everything on main again now! |
|
🚨 API breaking changes detected! 🚨 |
|
🚨 API breaking changes detected! 🚨 |
atravitz
force-pushed
the
test_against_gufe_main
branch
from
8ccd6e4 to
bb3b75e
Compare
|
🚨 API breaking changes detected! 🚨 |
jthorton
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's my understanding that we want to keep CI red until #1033 is closed, but I'm switching us to have the majority of our matrix test against
mainso that we are more likely to catch any new bugs.