Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch settings input to protocol units to creating protocol itself. #700

Merged
merged 8 commits into from
Feb 7, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Feb 2, 2024

Fixes #694

Developers certificate of origin

@pep8speaks
Copy link

pep8speaks commented Feb 2, 2024

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 461:80: E501 line too long (86 > 79 characters)

Line 623:80: E501 line too long (101 > 79 characters)

Comment last updated at 2024-02-07 09:30:48 UTC

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bd5e7c) 91.33% compared to head (48b31c4) 91.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #700   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files         132      132           
  Lines        9328     9328           
=======================================
  Hits         8520     8520           
  Misses        808      808           
Flag Coverage Δ
fast-tests 91.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardjgowers richardjgowers merged commit 00ef4de into main Feb 7, 2024
9 checks passed
@richardjgowers richardjgowers deleted the protocol-to-units branch February 7, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Protocols to pass a copy of the protocol instead of settings
3 participants