Make parens optional for * EXCEPT and minor clean up
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingMob
force-pushed
the
push-wlxrpwulplux
branch
from
23afc4d to
875ea6c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 75.91% 75.94% +0.03%
==========================================
Files 30 30
Lines 1536 1534 -2
Branches 66 64 -2
==========================================
- Hits 1166 1165 -1
- Misses 304 305 +1
+ Partials 66 64 -2 ☔ View full report in Codecov by Sentry. |
KingMob
force-pushed
the
push-wlxrpwulplux
branch
from
875ea6c to
bcd9ab4
Compare
KingMob
force-pushed
the
push-rmqnwwwmmlps
branch
from
f8bff4b to
6ebfca9
Compare
KingMob
force-pushed
the
push-wlxrpwulplux
branch
from
bcd9ab4 to
debd205
Compare
KingMob
force-pushed
the
push-rmqnwwwmmlps
branch
from
6ebfca9 to
0110d7e
Compare
KingMob
force-pushed
the
push-wlxrpwulplux
branch
from
debd205 to
3247712
Compare
KingMob
force-pushed
the
push-rmqnwwwmmlps
branch
2 times, most recently
from
52a0fc3 to
1529fde
Compare
KingMob
force-pushed
the
push-wlxrpwulplux
branch
2 times, most recently
from
2cc075b to
d14f8ce
Compare
KingMob
force-pushed
the
push-rmqnwwwmmlps
branch
from
1529fde to
62930fc
Compare
KingMob
force-pushed
the
push-wlxrpwulplux
branch
from
d14f8ce to
4af32f6
Compare
Schaechtle
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes parentheses optional for the
SELECT * EXCEPTandGENERATE * EXCEPTcode, which were not originally created that way.It also adds a few missing parse tests, and simplifies and aligns their parse trees and plans.