Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate deps lock updates #96

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

srounce
Copy link
Collaborator

@srounce srounce commented Apr 1, 2024

The deps-lock.json file should be regenerated whenever deps.edn changes, rather than being edited by hand. This commit avoids having to manually do this chore by regenerating deps-lock.json automatically and commiting it to you branch. This automation is in an effort to avoid contributors getting blocked due to confusing errors when deps-lock.json has either not been regenerated or edited by hand.

This also exposes clj-nix's deps-locktool in the nix devshell to make it easier for people to run it manually if they need to during development.

@KingMob
Copy link
Contributor

KingMob commented Apr 2, 2024

Looks pretty cool. Can it detect if the deps-lock is out of sync, though, and skip making unneeded commits?

@srounce
Copy link
Collaborator Author

srounce commented Apr 2, 2024

@KingMob if the content of deps-lock.json doesn't change as a result of the run then no commit will be created

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.89%. Comparing base (32adb67) to head (f67869c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   75.89%   75.89%           
=======================================
  Files          30       30           
  Lines        1535     1535           
  Branches       64       64           
=======================================
  Hits         1165     1165           
  Misses        306      306           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srounce srounce force-pushed the automate-deps-lock-updates branch 4 times, most recently from a3c79fd to fb23367 Compare April 29, 2024 17:05
Copy link
Contributor

@ships ships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was prepared to merge this earlier but can't seem to get the required checks to run despite having hit "approve and run".

What is the necessary authority to run these checks?

I'll contact @srounce sidechannel about commit lint.

@srounce srounce force-pushed the automate-deps-lock-updates branch from fb23367 to a29cd49 Compare April 29, 2024 18:15
@KingMob
Copy link
Contributor

KingMob commented Apr 30, 2024

@ships I authorized the checks to run. Hopefully it will do that in the future, for at least this PR.

srounce added 2 commits May 1, 2024 09:02
The deps-lock.json file should be regenerated whenever deps.edn changes,
rather than being edited by hand. This commit avoids having to manually
do this chore by regenerating deps-lock.json automatically and commiting
it to you branch. This automation is in an effort to avoid contributors
getting blocked due to confusing errors when deps-lock.json has either
not been regenerated or edited by hand.
@ships ships force-pushed the automate-deps-lock-updates branch from a29cd49 to 40d6c79 Compare May 1, 2024 16:02
@KingMob
Copy link
Contributor

KingMob commented May 2, 2024

This looks blocked because the CI GH actions aren't running. I'm going to try to jump start it.

@KingMob KingMob marked this pull request as draft May 2, 2024 12:14
@KingMob KingMob marked this pull request as ready for review May 2, 2024 12:14
@KingMob
Copy link
Contributor

KingMob commented May 2, 2024

@srounce Can you check that you got the invitation to join the OpenGen GH group? It still shows as pending, which might be why your GH Actions jobs aren't running. Not sure.

I tried seeing if I could forcibly restart your GH Actions, but I'm not seeing the relevant ones in the log anywhere.

Failing that, it may be necessary to reopen this PR from a branch of OpenGen/GenSQL.query itself, instead of your fork.

@srounce srounce force-pushed the automate-deps-lock-updates branch from 3dd319e to 3ff4919 Compare May 3, 2024 12:39
@srounce srounce force-pushed the automate-deps-lock-updates branch from 3ff4919 to f67869c Compare May 3, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants