function to check if link list has cycle #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavb
requested changes
Nov 1, 2017
| while slow is not fast: | ||
| slow = slow.next | ||
| fast = fast.next.next | ||
| return true |
There was a problem hiding this comment.
In Python, true and false are capitalized.
There was a problem hiding this comment.
yeah i was asking @ayush94 if he tested it, clearly 'true' doesnt parse in python compiler 👯
|
Don't forgot to read the contribution guidelines 😄 Naming convention: folders and filenames should be in lowercase and each word separated by _. Names should be descriptive to certain extend. 👍 Every code contribution may contain the following comment as a part of it: |
|
@arthurlacoste The comment you mentioned is no longer necessary, and @AdiChat should update the contributing guidelines based on that. |
arnavb
approved these changes
Nov 6, 2017
|
Looks great 😍 Hope you are enjoying your journey 🚆 with OpenGenus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality #2921
Changes:
a python file added under link_list code that defines a function to check whether a link list has a cycle or not