Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections MVP #435

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Collections MVP #435

merged 6 commits into from
Jun 27, 2024

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jun 19, 2024

Closes #266

I quickly put together an MVP for collections. A collection is a list of models with a name, description, and author. Each collection has its own page like this:

image

Collections are linked to by the models they contain and on their authors' pages:

image
image


TODO:

  • Improve the design of collection cards. They are too similar to model cards. I want to eventually show collections on the home page, so they need to be visually distinct.
  • Add a way to add collections.
  • Add a way to add/remove/reorder models in collections.

@joeyballentine
Copy link
Contributor

Are those TODOs for this PR or just future work? I haven't reviewed this yet because I thought you still had work to do on it

@RunDevelopment
Copy link
Member Author

Sorry, it took a while. I resolved all TODOs.

Copy link
Contributor

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the hard work 👍

@joeyballentine joeyballentine merged commit 44f7c41 into main Jun 27, 2024
4 checks passed
@joeyballentine joeyballentine deleted the collections branch June 27, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add model collections
2 participants