Minimal support for Mistral 7B model. #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Yeah that what I did, but I create more operation for sliding instead of using split. I will push this with chunking of input. |
There was a problem hiding this comment.
I think we need to assign self.sliding_window of spec to be added in model later.
There was a problem hiding this comment.
Where is it used later? but yes can't hurt to add it.
There was a problem hiding this comment.
I think to add a variable into model.bin, the variable sliding_window have to be a member of class spec, if it is not, it will not be added to model in convert process.
|
closing this one, reviewing #1524 with @minhthuc2502 taking into account the input chunking. |
vince62s
changed the title
funboarder13920
pushed a commit
to funboarder13920/CTranslate2
that referenced
this pull request
Nov 7, 2023
This reverts commit 50e9ba4.
funboarder13920
pushed a commit
to funboarder13920/CTranslate2
that referenced
this pull request
Nov 7, 2023
This reverts commit 8090f5f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@minhthuc2502 Maybe check this code