Skip to content

Commit

Permalink
front: upgrade node to v23
Browse files Browse the repository at this point in the history
A newer node version is required [1] to make require() work with
modules. This is necessary for a nivo upgrade, otherwise CI fails
with:

     FAIL  src/modules/rollingStock/components/RollingStockEditor/__tests__/RollingStockEditorForm.spec.ts [ src/modules/rollingStock/components/RollingStockEditor/__tests__/RollingStockEditorForm.spec.ts ]
    Error: require() of ES Module /app/node_modules/d3-interpolate/src/index.js from /app/node_modules/@nivo/core/dist/nivo-core.cjs.js not supported.
    Instead change the require of index.js in /app/node_modules/@nivo/core/dist/nivo-core.cjs.js to a dynamic import() which is available in all CommonJS modules.
     ❯ Object.<anonymous> node_modules/@nivo/core/dist/nivo-core.cjs.js:1:164

[1]: plouc/nivo#2310 (comment)

Signed-off-by: Simon Ser <[email protected]>
  • Loading branch information
emersion committed Jan 20, 2025
1 parent c4c4c58 commit 10127c6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion front/docker/Dockerfile.devel
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ COPY docker/exec-as.c .
RUN gcc -std=c99 -static -o /exec-as exec-as.c


FROM node:20
FROM node:23

# Install dependencies
RUN apt-get update -yqq && \
Expand Down
2 changes: 1 addition & 1 deletion front/docker/Dockerfile.nginx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### BUILD STAGE

FROM node:20-bookworm AS build
FROM node:23-bookworm AS build

WORKDIR /app

Expand Down

0 comments on commit 10127c6

Please sign in to comment.