Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash due to BLE sensor data reported after shutdown #1793

Merged
merged 5 commits into from
Dec 26, 2023
Merged

Conversation

dennisguse
Copy link
Member

Problem(s):

  • TrackListActivity started sensors and recording (always).
  • The TrackRecordingService checked only if a recording was running and NOT if the sensors were already started.

Follow-up:

  • Shutdown of sensors may not been correct for quite a while
  • Sensor data shouldn't have been affected

Moreover: TrackListActivity's start and stop sensor didn't work correctly.

@dennisguse dennisguse linked an issue Dec 25, 2023 that may be closed by this pull request
@dennisguse dennisguse merged commit 81a7882 into main Dec 26, 2023
3 of 5 checks passed
@dennisguse dennisguse deleted the crash#1708 branch December 26, 2023 08:04
@Mats391
Copy link

Mats391 commented Dec 26, 2023

I tested the latest nightly including this fix with my heart rate sensor and it no longer crashes. I restarted recording and the app multiple times and it worked in all tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bluetooth sensors cause crash
2 participants